1658031 - Don't update print preview when changing copies

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P3)

Description

[Asif Youssuff]

Steps to reproduce:

1. Open a web page
2. Do control-p
3. change number of copies

What happens:

Every time the number of copies is changed, the classic Print Preview dialog appears for a split second.

Expected result:

Print Preview dialog should not appear.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Could you add a little more information? I'm not seeing this on MacOS…

Comment 2

[Asif Youssuff]

Attachment: 2020-08-07 18-44-43.mkv

Blake, I attached a video showing the issue.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Huh. Interesting…

I think I remember someone talking about something related to this in one of the meetings, so hopefully we'll be able to get it fixed.

Comment 4

[Jonathan Watt [:jwatt]]

Thanks, Asif. Would you mind exporting the video to one of the video formats natively supported by Firefox?

https://support.mozilla.org/en-US/kb/html5-audio-and-video-firefox#w_supported-formats

Comment 5

[Jonathan Watt [:jwatt]]

The dialog that is being displaying is the print progress dialog. I discussed this late on Friday with mstriemer and pointed him to nsIPrintSettings.showPrintProgress. Setting that to false should get rid of the dialog, which presumably we'll get to trying out early next week.

Comment 6

[Asif Youssuff]

Attachment: 2020-08-07 18-44-43.mp4

Attached the video in a mp4 container.

Comment 7

[Mark Striemer [:mstriemer]]

I added a comment to bug 1653323 so we can hide the progress dialog while the preview is loading.

However we shouldn't be updating the preview when a feature changes that won't affect the preview. So in the copies case I don't think we should be updating the preview.

From an implementation standpoint, I think we only need to update the preview if a setting has an associated flag.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Can you set a priority and severity?

Comment 9

[Emma Malysz]

Attachment: Bug 1658031, update print preview only for settings with flags to avoid a progress dialog

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d95ae26b4a96
update print preview only for settings with flags to avoid a progress dialog r=mstriemer

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d95ae26b4a96

Comment 12

[Anca Soncutean, Desktop QA]

Reproduced with 81.0a1 (2020-08-07) on Windows 10.
Verified fixed with 81.0a1 (2020-08-24) on Windows 10, macOS 10.15 and Ubuntu 18.04.