1658262 - Print Preview doesn’t get closed/updated if navigating to a different webpage on the same tab

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: printPrev.gif

Affected versions

• 81.0a1 (BuildId:20200804215246)

Affected platforms

• Windows 10 64bit
• macOS 10.14
• Ubuntu 18.04 64bit

Preconditions

• Ensure that the print.tab_modal.enabled pref is set to true

Steps to reproduce

1. Launch Firefox.
2. Access the following link
3. Click on any link from the page to reach out to a new article within the same tab.
4. Open the print preview.
5. Click the back button in order to reach the previous article.

Expected result

• The print preview closes (like in Chrome) or the page gets updated (in print preview) reflecting the current tab’s content.

Actual result

• The print preview displays the first page (doesn’t update with the page currently displayed in the tab). If the user goes ahead and initiates a print job from the print preview it will print the current page (displayed inside the tab not inside the print preview).

Regression Range

• I don’t think that this is a regression

Notes

• For further information regarding this issue, please observe the attached screencast.
• A workaround for this is to reopen the print preview.
• [Suggested Severity] I think that S3 fits for this one.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Should we let people navigate the tab behind? I think, since the print dialog is a tab-modal, it should block everything that goes to the page behind do… (But then we get into problems with sites that auto-update, which we probably shouldn't prevent?)

Comment 2

[:Gijs (he/him)]

(In reply to Blake Winton (:bwinton) (:☕️) from comment #1)

Should we let people navigate the tab behind? I think, since the print dialog is a tab-modal, it should block everything that goes to the page behind do… (But then we get into problems with sites that auto-update, which we probably shouldn't prevent?)

I think any user-initiated navigation should close the dialog. I assumed that opening the print dialog already suppresses page-initiated navigation - we already do this for other dialogs like alert(). We should be able to use the same machinery here.

Comment 4

[Mark Striemer [:mstriemer]]

There's also bug 1657506 about interacting with the page, you could keyboard focus into it too.

These are issues that I was hoping would be fixed by the move to TabDialogBox but that feature hasn't landed yet. We have bug 1653317 to switch to TabDialogBox but it could be time to start preventing these interactions rather than moving to TabDialogBox for 81.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

(Whoops, the parent bug was re-opened.)

Comment 7

[Blake Winton (:bwinton) (:☕️)]

(Like the parent bug, this should also be fixed by bug 1653317 so removing the [print2020_v81] whiteboard tag for easier tracking.)

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 81.0a1 (BuildId:20200820212107) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.

Comment 9

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1081132