1658469 - Assertion failure: mIsUAWidget, at dom/base/ShadowRoot.cpp:613

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

When I try to reproduce bug 1657911 on a local debug build, opening https://en.wikipedia.org/wiki/United_States and try to print preview the document, I got an assertion in ShadowRoot::ImportNodeAndAppendChildAt.

I am trying to biset which commit causes the assertion, but it seems it's not a recent regression, I saw a similar assertion on 74.

Emilio told me that we need to copy mIsUAWidget in ShadowRoot::CloneInternalDataFrom, even with the change I got another assertion;

Assertion failure: 1 >= mContent->GetShadowRoot()->GetChildCount(), at layout/generic/nsVideoFrame.cpp:159

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: rr-log.txt

I got the same assertion when loading https://www.bbc.com/future/article/20200806-are-face-shields-effective-against-covid-19 (bug 1657906) in my local debug build's print-preview. Attached the relevant rr-log.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch to avoid the crash

FWIW, here is a patch I've been using locally to avoid the crash.

The crash is pretty often happening during print preview, so I hope this will mitigate it in developing some other things in print related works.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1658469 - Don't clone UA widgets for printing. r=smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8a07fc83ed
When cloning a shadow root for printing, also copy the UA-widget-ness. r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08a78618c76c
Fix new test so that we actually load the second page.

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for assertion failures on nsVideoFrame.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/7c3c7f44c7cee5df430843e6ef927c8e55804cb2

push: -started appearing here: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=JUsU5d6PSDedJz6QcZTP1Q.0&revision=2da7f3274e8d1026ecd65fe1fc9ace93c06bd711&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64-qr%2Fdebug-mochitest-chrome-1proc%2Cc3 - backfilled and retriggered down to this bug.

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312943968&repo=autoland&lineNumber=118148

/base/nsPresContext.cpp, line 864
[task 2020-08-13T17:58:58.168Z] 17:58:58 INFO - GECKO(10759) | Assertion failure: 1 >= mContent->GetShadowRoot()->GetChildCount(), at /builds/worker/checkouts/gecko/layout/generic/nsVideoFrame.cpp:159
[task 2020-08-13T17:58:58.196Z] 17:58:58 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2020-08-13T17:58:58.200Z] 17:58:58 INFO - fix-stacks error: failed to run /builds/worker/workspace/build/tests/bin/fileid for /builds/worker/workspace/build/application/firefox/libxul.so
[task 2020-08-13T17:58:58.201Z] 17:58:58 INFO - GECKO(10759) | #01: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7316801]
[task 2020-08-13T17:58:58.202Z] 17:58:58 INFO - GECKO(10759) | #02: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72dae13]
[task 2020-08-13T17:58:58.204Z] 17:58:58 INFO - GECKO(10759) | #03: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x720ef11]
[task 2020-08-13T17:58:58.205Z] 17:58:58 INFO - GECKO(10759) | #04: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x720e851]
[task 2020-08-13T17:58:58.206Z] 17:58:58 INFO - GECKO(10759) | #05: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x720b55d]
[task 2020-08-13T17:58:58.210Z] 17:58:58 INFO - GECKO(10759) | #06: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7208467]
[task 2020-08-13T17:58:58.211Z] 17:58:58 INFO - GECKO(10759) | #07: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72040a7]
[task 2020-08-13T17:58:58.211Z] 17:58:58 INFO - GECKO(10759) | #08: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7200d3c]
[task 2020-08-13T17:58:58.211Z] 17:58:58 INFO - GECKO(10759) | #09: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x720da9c]
[task 2020-08-13T17:58:58.211Z] 17:58:58 INFO - GECKO(10759) | #10: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x720a5ce]
[task 2020-08-13T17:58:58.211Z] 17:58:58 INFO - GECKO(10759) | #11: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72085b9]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #12: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72040a7]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #13: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7200d3c]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #14: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72216c3]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #15: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7220b8b]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #16: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71f8d00]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #17: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72e33e8]
[task 2020-08-13T17:58:58.212Z] 17:58:58 INFO - GECKO(10759) | #18: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71f8d00]
[task 2020-08-13T17:58:58.215Z] 17:58:58 INFO - GECKO(10759) | #19: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72e3bd2]
[task 2020-08-13T17:58:58.215Z] 17:58:58 INFO - GECKO(10759) | #20: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72e3dcc]
[task 2020-08-13T17:58:58.216Z] 17:58:58 INFO - GECKO(10759) | #21: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72216c3]
[task 2020-08-13T17:58:58.216Z] 17:58:58 INFO - GECKO(10759) | #22: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71e1677]
[task 2020-08-13T17:58:58.217Z] 17:58:58 INFO - GECKO(10759) | #23: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71f8d00]
[task 2020-08-13T17:58:58.217Z] 17:58:58 INFO - GECKO(10759) | #24: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72e6bf9]
[task 2020-08-13T17:58:58.218Z] 17:58:58 INFO - GECKO(10759) | #25: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72216c3]
[task 2020-08-13T17:58:58.218Z] 17:58:58 INFO - GECKO(10759) | #26: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72551c2]
[task 2020-08-13T17:58:58.219Z] 17:58:58 INFO - GECKO(10759) | #27: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x72559de]
[task 2020-08-13T17:58:58.219Z] 17:58:58 INFO - GECKO(10759) | #28: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7258754]
[task 2020-08-13T17:58:58.220Z] 17:58:58 INFO - GECKO(10759) | #29: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71f8d00]
[task 2020-08-13T17:58:58.220Z] 17:58:58 INFO - GECKO(10759) | #30: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71f88f1]
[task 2020-08-13T17:58:58.221Z] 17:58:58 INFO - GECKO(10759) | #31: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7139efd]
[task 2020-08-13T17:58:58.221Z] 17:58:58 INFO - GECKO(10759) | #32: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7140f07]
[task 2020-08-13T17:58:58.222Z] 17:58:58 INFO - GECKO(10759) | #33: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x71406b8]
[task 2020-08-13T17:58:58.223Z] 17:58:58 INFO - GECKO(10759) | #34: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74b5dd4]
[task 2020-08-13T17:58:58.223Z] 17:58:58 INFO - GECKO(10759) | #35: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74b4fc7]
[task 2020-08-13T17:58:58.224Z] 17:58:58 INFO - GECKO(10759) | #36: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74b2726]
[task 2020-08-13T17:58:58.224Z] 17:58:58 INFO - GECKO(10759) | #37: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74b07f7]
[task 2020-08-13T17:58:58.225Z] 17:58:58 INFO - GECKO(10759) | #38: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74afbd2]
[task 2020-08-13T17:58:58.225Z] 17:58:58 INFO - GECKO(10759) | #39: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x74b29f7]
[task 2020-08-13T17:58:58.227Z] 17:58:58 INFO - GECKO(10759) | #40: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x7197da0]
[task 2020-08-13T17:58:58.227Z] 17:58:58 INFO - GECKO(10759) | #41: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x413f212]
[task 2020-08-13T17:58:58.228Z] 17:58:58 INFO - GECKO(10759) | #42: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x4b8e66e]
[task 2020-08-13T17:58:58.228Z] 17:58:58 INFO - GECKO(10759) | #43: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x4b8e466]
[task 2020-08-13T17:58:58.229Z] 17:58:58 INFO - GECKO(10759) | #44: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x4b8fb3b]
[task 2020-08-13T17:58:58.229Z] 17:58:58 INFO - GECKO(10759) | #45: ??? (???:???)
[task 2020-08-13T17:58:58.230Z] 17:58:58 INFO - GECKO(10759) | ExceptionHandler::GenerateDump cloned child 11158
[task 2020-08-13T17:58:58.230Z] 17:58:58 INFO - GECKO(10759) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2020-08-13T17:58:58.231Z] 17:58:58 INFO - GECKO(10759) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2020-08-13T17:58:58.373Z] 17:58:58 INFO - GECKO(10759) | Exiting due to channel error.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45deb5ffb469
Don't clone UA widgets for printing. r=smaug

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/45deb5ffb469