Closed Bug 1659457 Opened 2 years ago Closed 2 years ago

Unstyled XML documents do not displayed correctly in print/print preview

Categories

(Core :: Print Preview, defect, P3)

Firefox 81
defect

Tracking

()

VERIFIED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- unaffected
firefox81 --- verified

People

(Reporter: Anca, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v81] [old-ui+])

Attachments

(2 files, 1 obsolete file)

Attached image Beta vs Nightly.png

Affected versions

  • 81.0a1

Affected platforms

  • Windows 10
  • macOS 10.15
  • Ubuntu 18.04

Steps to reproduce

  1. Launch Firefox
  2. Make sure the print UI via print.tab_modal.enabled is set on true
  3. Open https://www.w3schools.com/xml/cd_catalog.xml
  4. Hit CTRL + P
  5. Observe the Print Preview content

Expected result

  • The print preview/ print to paper output matches the website content

Actual result

    • The print preview/ print to paper output doesn’t match the website content

Regression range

Suggested severity

  • I think that S3 is suitable for this issue
Summary: The content for XML Webpages are not displayed correctly in print preview / print to paper → The content for XML Webpages is not displayed correctly in print preview / print to paper
Component: Printing → Print Preview
Product: Toolkit → Core
Severity: -- → S3
Priority: -- → P2

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #0)

Regression range

Emilio, this is low priority, so only answer this if you know offhand. :-) Could the shadow root changes in bug 1658469 have broken the mechanism we use to format raw XML as markup?

Flags: needinfo?(emilio)
Priority: P2 → P3
Summary: The content for XML Webpages is not displayed correctly in print preview / print to paper → Unstyled XML documents do not displayed correctly in print/print preview
Assignee: nobody → emilio
Has Regression Range: --- → yes
Regressed by: 1658469
Flags: needinfo?(emilio)

There's no real security benefit for using a UAWidget for XML pretty
printing. This ensures the pretty printing shadow root is cloned during
printing just like regular shadow DOM is.

Set release status flags based on info from the regressing bug 1658469

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a5007462432
Do clone xml-pretty-printer's UA widget. r=smaug
Whiteboard: [print2020_v81] → [print2020_v81] [old-ui+]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

This is verified fixed using 81.0a1 (BuildId:20200820212107) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04.

Verified that this issue is no longer reproducible with the new & old ui.

Status: RESOLVED → VERIFIED
Regressions: 1660490
Attachment #9170659 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.