1659457 - Unstyled XML documents do not displayed correctly in print/print preview

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P3)

Description

[Anca Soncutean, Desktop QA]

Attachment: Beta vs Nightly.png

Affected versions

• 81.0a1

Affected platforms

• Windows 10
• macOS 10.15
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox
2. Make sure the print UI via print.tab_modal.enabled is set on true
3. Open https://www.w3schools.com/xml/cd_catalog.xml
4. Hit CTRL + P
5. Observe the Print Preview content

Expected result

• The print preview/ print to paper output matches the website content

Actual result

• • The print preview/ print to paper output doesn’t match the website content

Regression range

• I couldn't go further than this with the regression range:
• First bad: ffc01c0f13a841719e86d032ac27fe9dbc1fc5f7 (2020-08-15)
• Last good: 9bfa6276ddc55be311c681960647e96317589a0d (2020-08-14)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9bfa6276ddc55be311c681960647e96317589a0d&tochange=ffc01c0f13a841719e86d032ac27fe9dbc1fc5f7

Suggested severity

• I think that S3 is suitable for this issue

Comment 1

[Jonathan Watt [:jwatt]]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #0)

Regression range

• I couldn't go further than this with the regression range:
• First bad: ffc01c0f13a841719e86d032ac27fe9dbc1fc5f7 (2020-08-15)
• Last good: 9bfa6276ddc55be311c681960647e96317589a0d (2020-08-14)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9bfa6276ddc55be311c681960647e96317589a0d&tochange=ffc01c0f13a841719e86d032ac27fe9dbc1fc5f7

Emilio, this is low priority, so only answer this if you know offhand. :-) Could the shadow root changes in bug 1658469 have broken the mechanism we use to format raw XML as markup?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yes, we use an UA widget for that: https://searchfox.org/mozilla-central/rev/fa7f47027917a186fb2052dee104cd06c21dd76f/dom/xml/nsXMLPrettyPrinter.cpp#88

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1659457 - Back out bug 1510406. r=smaug

There's no real security benefit for using a UAWidget for XML pretty
printing. This ensures the pretty printing shadow root is cloned during
printing just like regular shadow DOM is.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1658469

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1659457 - Do clone xml-pretty-printer's UA widget. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a5007462432
Do clone xml-pretty-printer's UA widget. r=smaug

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8a5007462432

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using 81.0a1 (BuildId:20200820212107) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04.

Verified that this issue is no longer reproducible with the new & old ui.

Comment 9

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1082823