1658620 - Figure out interaction between private search result and search mode

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Harry Twyford]

We show a "Search in a Private Window" result when only suggestions are shown. Selecting that result opens the search term in a private window.

Currently, with the update2 pref disabled, if the user highlights that result and Alt+Tabs down to the one-offs, we open a search in a new private window:

• with the private engine if one has been specified
• with the selected one-off engine if the user hasn't chosen a separate private default

With update2 enabled, we enter search mode in the current window. We always enter the selected one-off engine's search mode, ignoring the separate private default. This is wrong both in that it doesn't open PBM and it might use the wrong engine.

We should probably open search mode in a new PBM window. We should preserve the user's query, and select which engine to use based off the logic in the bullet points above.

Comment 1

[Marco Bonardo [:mak]]

Or we should remove these results and rather provide a Private Search one-off button?

Comment 2

[Marco Bonardo [:mak]]

From yesterday meeting, we are still evaluating separate private default, and may disable the feature in Nightly.

Comment 3

[Marco Bonardo [:mak]]

This bug is just for future reference, since private search is currently disabled. If/when we re-enable it, then we must figure out this bug.

Comment 4

[Marco Bonardo [:mak]]

when doing this, we should rewrite the tests in browser_separatePrivateDefault.js and browser_separatePrivateDefault_differentEngine.js