1658629 - Update heuristic action when cycling through local one-offs with a search string

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Harry Twyford]

The action text on heuristic search results reads Search with <engine name>. When you move through the one offs with the keyboard, that text updates to Search with <one-off engine name>, because if you hit enter, a search would be executed with that one-off's engine.

With update2/oneOffsRefresh enabled, we display the same action text even though pressing enter would enter search mode with that engine, not execute a search. We should consider updating that string to Enter search mode with <one-off engine name> or something similar.

This would be a P3, except for that we show no action text at all for the local one-offs, which isn't at all indicative of what will happen when the user hits enter. This is a similar problem to bug 1657918.

I've already run this past UX and I'm waiting to hear back.

Comment 1

[Harry Twyford]

Attachment: local2-121.jpg

UX got back to me. When (alt+)arrowing through the local one-offs, we should show a local one off heuristic result. It displays the icon for that search mode, the search string, and the action text Search <result type>. Selecting it opens that particular local search mode. This result is only shown when arrowing through the one-offs and should not be shown in any other context.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1658629 - Update heuristic action when cycling through local one-offs with a search string. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91203c07d8e
Update heuristic action when cycling through local one-offs with a search string. r=adw,fluent-reviewers,flod

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f91203c07d8e