Closed Bug 1658629 Opened 8 months ago Closed 7 months ago

Update heuristic action when cycling through local one-offs with a search string

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
3

Tracking

()

RESOLVED FIXED
83 Branch
Iteration:
83.1 - Sept 21 - Oct 4
Tracking Status
firefox83 --- fixed

People

(Reporter: harry, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The action text on heuristic search results reads Search with <engine name>. When you move through the one offs with the keyboard, that text updates to Search with <one-off engine name>, because if you hit enter, a search would be executed with that one-off's engine.

With update2/oneOffsRefresh enabled, we display the same action text even though pressing enter would enter search mode with that engine, not execute a search. We should consider updating that string to Enter search mode with <one-off engine name> or something similar.

This would be a P3, except for that we show no action text at all for the local one-offs, which isn't at all indicative of what will happen when the user hits enter. This is a similar problem to bug 1657918.

I've already run this past UX and I'm waiting to hear back.

Attached image local2-121.jpg

UX got back to me. When (alt+)arrowing through the local one-offs, we should show a local one off heuristic result. It displays the icon for that search mode, the search string, and the action text Search <result type>. Selecting it opens that particular local search mode. This result is only shown when arrowing through the one-offs and should not be shown in any other context.

Points: --- → 3
Keywords: blocked-ux
Summary: Change heuristic action text when tabbing through update2 one-offs → Show local search result when cycling through local one-offs
Assignee: nobody → mak
Status: NEW → ASSIGNED
Iteration: --- → 83.1 - Sept 21 - Oct 4
Summary: Show local search result when cycling through local one-offs → Update heuristic action when cycling through local one-offs with a search string
Blocks: 1667766
Blocks: 1667795
Blocks: 1647923
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f91203c07d8e
Update heuristic action when cycling through local one-offs with a search string. r=adw,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Regressions: 1668370
You need to log in before you can comment on or make changes to this bug.