1668370 - Cycling through local one-offs changes the engine name in keywordoffer results

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Harry Twyford]

STR:

1. Have at least one search shortcut Top Site. This STR uses Google, but any engine will do.
2. Open the Urlbar without a search string and arrow down to the one-offs.
3. Observe the Google Top Site result reads "Search with Google"
4. Arrow down to the bookmark one-off.

Expected results:
The Google Top Site result reads "Search with Google"

Actual results:
The Google Top Site result reads "Search with Bookmarks"

Notes:

• The Top Site result text continues to change as you arrow over to the Tabs and History one-offs.
• Clicking the Top Site result with the changed text opens the original engine's search mode, as expected. Google, in this example.

Comment 1

[Harry Twyford]

Oh! I think this should be fixed by bug 1647923. The problem is that keywordoffer results use their action text as their title. I think that was a workaround to avoid having to localize a result's title. Bug 1658629 changes the keywordoffer's action text when cycling to the local one-offs and thus changes its title. Bug 1647923 changes keywordoffer results to set a title instead of using their action text as one. I'll verify this is fixed once bug 1647923 is merged.

Comment 2

[Marco Bonardo [:mak]]

Not fixed yet, afaict. Indeed now the shortcut shows the action text (as Search Bookmarks) while it shouldn't. Fwiw, we should not change the action text of keywordoffer, even when cycling through one-offs. It's probably a case I missed.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1658629

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1668370 - Cycling through local one-offs changes the engine name in keywordoffer results. r=harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a639b0c8982
Cycling through local one-offs changes the engine name in keywordoffer results. r=harry

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3a639b0c8982