1658679 - remoteautomation.py should handle mozdevice.get_file returning bytes in Python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

Bug 1650915 reverted the python 3 changes to mozdevice.get_file which had changed the return type to be str. Under Python 3 it now will return bytes resulting in a TypeError attempting to concat a str and a bytes in RemoteAutomation.read_stdout().

Traceback (most recent call last):
  File "_tests/reftest/remotereftest.py", line 450, in run_test_harness
    retVal = reftest.runTests(options.tests, options)
  File "_tests/reftest/runreftest.py", line 631, in runTests
    return self.runSerialTests(manifests, options, cmdargs)
  File "_tests/reftest/runreftest.py", line 972, in runSerialTests
    return run()
  File "_tests/reftest/runreftest.py", line 946, in run
    status = self.runApp(
  File "_tests/reftest/remotereftest.py", line 389, in runApp
    status, self.lastTestSeen = self.automation.runApp(None, env,
  File "_tests/reftest/remoteautomation.py", line 82, in runApp
    status = self.waitForFinish(timeout, maxTime)
  File "_tests/reftest/remoteautomation.py", line 132, in waitForFinish
    status = self.wait(timeout=maxTime, noOutputTimeout=timeout)
  File "_tests/reftest/remoteautomation.py", line 371, in wait
    hasOutput = self.read_stdout()
  File "_tests/reftest/remoteautomation.py", line 285, in read_stdout
    self.logBuffer += newLogContent

A similar issue was already fixed in testing/gtest/remotegtests.py.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1650915

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1658679 - Fix Python 3 compatibility in RemoteAutomation.read_stdout().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/699110b9e6fd
Fix Python 3 compatibility in RemoteAutomation.read_stdout(). r=jmaher

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/699110b9e6fd