1658712 - Non-data variant of GeckoViewPushController.onEvent calls nsIPushNotifier.notifyPush with too few arguments, omitting `messageId`

Status: RESOLVED DUPLICATE of bug 1693477

(GeckoView :: General, defect)

Description

[[e-mail]]

Attachment: FF_push.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
Firefox for Android

Steps to reproduce:

Push notifications to Firefox Beta rv:8-.0 for Android 10.

Actual results:

Notification did not show and an error was shown in console

(NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIPushNotifier.notifyPush])

Expected results:

Notifications should work, and errors should be traceable.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Thank you for filing this! It appears this call in GeckoView is trying to call this method but is missing the third argument and it seems like it has been this way since bug 1343678 landed, enabling push.

Comment 3

[Makoto Kato [:m_kato]]

I have landed the fix by bug 1693477 today.

Comment 4

[[e-mail]]

(In reply to Makoto Kato [:m_kato] from comment #3)

*** This bug (1658712 ) has been marked as a duplicate of bug 1693477 ***

Nice time machine.