Closed Bug 1658788 Opened 4 years ago Closed 4 years ago

Port bug 1657582 - comm/ldap/xpcom/src/nsLDAPConnection.cpp:158:67: error: too few arguments to function call, expected 8, have 6

Categories

(Thunderbird :: Upstream Synchronization, defect)

defect

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: jorgk-bmo, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

/builds/worker/checkouts/gecko/comm/ldap/xpcom/src/nsLDAPConnection.cpp:158:67: error: too few arguments to function call, expected 8, have 6

/builds/worker/checkouts/gecko/comm/ldap/xpcom/src/nsLDAPConnection.cpp:457:31: error: no member named 'GetScriptableNextAddr' in 'nsIDNSRecord'

Sorry 'bout the bustage, wasn't me :-(

Summary: comm/ldap/xpcom/src/nsLDAPConnection.cpp:158:67: error: too few arguments to function call, expected 8, have 6 → Port bug 1657582 - comm/ldap/xpcom/src/nsLDAPConnection.cpp:158:67: error: too few arguments to function call, expected 8, have 6
Blocks: 1657582
Attached patch 1658788.patch (obsolete) — Splinter Review

See whether this compiles.

Attached patch 1658788.patchSplinter Review

This does.

Attachment #9169679 - Attachment is obsolete: true
Comment on attachment 9169680 [details] [diff] [review]
1658788.patch

Review of attachment 9169680 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks like what I'm trying out
Attachment #9169680 - Flags: review+
Target Milestone: --- → 81 Branch

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a1bf45104c72
Port bug 1657582: More parameters to nsIDNSService.AsyncResolveNative(), etc. r=mkmelin

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9169680 [details] [diff] [review]
1658788.patch

Hi Valentin, could you please cast on eye onto this. Just out of interest, why did you introduce a new API nsIDNSAddrRecord?

Attachment #9169680 - Flags: feedback?(valentin.gosu)
Comment on attachment 9169680 [details] [diff] [review]
1658788.patch

Review of attachment 9169680 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good.

nsIDNSAddrRecord was needed because we can not return multiple nsIDNSRecord types to OnLookupComplete.
A method like `getNextAddr()` doesn't make sense for DNS records like TXT or HTTPS.

PS. Sorry for the breakage.
Attachment #9169680 - Flags: feedback?(valentin.gosu) → feedback+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: