Closed Bug 1658829 Opened 6 months ago Closed 5 months ago

Make all about:pioneer content available off-train

Categories

(Firefox :: Pioneer, enhancement, P1)

Product:
Firefox
Component:
Pioneer
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: rhelmer, Assigned: rhelmer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1658829 - make all about:pioneer content available off-train r?sfoster
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-release+
Details | Review

It's clear from further product review that we are not going to have copy ready on timelines that align with the Firefox release schedule, which is something I clearly didn't understand from earlier planning discussions (sorry!)

I've put together a simple patch for this, it does not try to integrate well with Fluent yet. We already have this problem with the study cards, I'd like to get to the point where we are delivering Fluent bundles instead but properly supporting different locales off-train will be more work.

Priority: -- → P1
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55175e7ad95b
make all about:pioneer content available off-train r=sfoster

Backed out for failures on browser_pioneer_ui.js

backout: https://hg.mozilla.org/integration/autoland/rev/e057d5c4d027f2b1bdf44812583cf75a3d76c66b

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=55175e7ad95b82e768eab0581ad98e527d5a3d65

push where the failure appeared: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s%2Cbc12&revision=624001c8d30c3ab0643199ab57c6d771cff9c85c&selectedTaskRun=ArTXWyu6TKaIX8nUYp3Udg.0 traced back to this bug

failure log:* https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312985684&repo=autoland&lineNumber=13307

[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | Confirming we saw 20 DOCSHELL created and 20 destroyed log strings.
[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | Confirming we saw 56 DOMWINDOW created and 56 destroyed log strings.
[task 2020-08-14T02:56:19.019Z] 02:56:19 ERROR - TEST-UNEXPECTED-FAIL | browser/components/pioneer/test/browser/browser_pioneer_ui.js | leaked 6 window(s) until shutdown [url = about:pioneer]
[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | windows(s) leaked: [pid = 3680] [serial = 15], [pid = 3680] [serial = 14], [pid = 3680] [serial = 12], [pid = 3680] [serial = 22], [pid = 3680] [serial = 24], [pid = 3680] [serial = 17]
[task 2020-08-14T02:56:19.019Z] 02:56:19 ERROR - TEST-UNEXPECTED-FAIL | browser/components/pioneer/test/browser/browser_pioneer_ui.js | leaked 3 docShell(s) until shutdown
[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | docShell(s) leaked: [pid = 3680] [id = {f1614c53-5cf7-4e8a-b759-ab33efeb1ce7}], [pid = 3680] [id = {01be2890-5a8f-4bdf-92ff-e4ecc898e874}], [pid = 3680] [id = {7de368b1-9c33-486c-9e12-a8de16fb71ca}]
[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | This test created 1 hidden window(s)
[task 2020-08-14T02:56:19.019Z] 02:56:19 INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | This test created 1 hidden docshell(s)

Flags: needinfo?(rhelmer)
Flags: needinfo?(rhelmer)
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a85d32ba77f
make all about:pioneer content available off-train r=sfoster,fluent-reviewers,flod

Backed out changeset 4a85d32ba77f (bug 1658829) for browser_pioneer_ui.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=c_TP7BI7Q7SW8B7kr6ZpTg.0&fromchange=4a85d32ba77f33a6b245d905df83a4a8c927a17d&searchStr=mochitest-browser-chrome&tochange=71a6d628bf09d8b3da26510d75b16b07ca7cdee2

Backout link: https://hg.mozilla.org/integration/autoland/rev/71a6d628bf09d8b3da26510d75b16b07ca7cdee2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313054686&repo=autoland&lineNumber=3526

...
...
...
[task 2020-08-14T19:43:32.614Z] 19:43:32     INFO - GECKO(1400) | [Parent 1400: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x129755400) [pid = 1400] [serial = 13] [outer = 0x0] [url = about:pioneer]
[task 2020-08-14T19:43:32.614Z] 19:43:32     INFO - GECKO(1400) | [Parent 1400: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x12917fc00) [pid = 1400] [serial = 23] [outer = 0x0] [url = about:pioneer]
[task 2020-08-14T19:43:32.650Z] 19:43:32     INFO - GECKO(1400) | [Parent 1400, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-08-14T19:43:32.726Z] 19:43:32     INFO - GECKO(1400) | [Parent 1400, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp, line 4343
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | Main app process: exit 0
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | Confirming we saw 20 DOCSHELL created and 20 destroyed log strings.
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | Confirming we saw 57 DOMWINDOW created and 57 destroyed log strings.
[task 2020-08-14T19:43:32.730Z] 19:43:32    ERROR - TEST-UNEXPECTED-FAIL | browser/components/pioneer/test/browser/browser_pioneer_ui.js | leaked 6 window(s) until shutdown [url = about:pioneer]
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | windows(s) leaked: [pid = 1400] [serial = 11], [pid = 1400] [serial = 23], [pid = 1400] [serial = 21], [pid = 1400] [serial = 16], [pid = 1400] [serial = 14], [pid = 1400] [serial = 13]
[task 2020-08-14T19:43:32.730Z] 19:43:32    ERROR - TEST-UNEXPECTED-FAIL | browser/components/pioneer/test/browser/browser_pioneer_ui.js | leaked 3 docShell(s) until shutdown
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | docShell(s) leaked: [pid = 1400] [id = {09a1994d-e504-674c-8b17-d5fc2a7e3276}], [pid = 1400] [id = {52536827-f6f8-9046-8802-9f8b6affecab}], [pid = 1400] [id = {1c05442c-380f-d140-86aa-c2539a816a27}]
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | This test created 0 hidden window(s)
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - TEST-INFO | browser/components/pioneer/test/browser/browser_pioneer_ui.js | This test created 1 hidden docshell(s)
[task 2020-08-14T19:43:32.730Z] 19:43:32     INFO - runtests.py | Application ran for: 0:00:22.812888
Flags: needinfo?(rhelmer)

Comment on attachment 9169703 [details]
Bug 1658829 - make all about:pioneer content available off-train r?sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: (I know it's super late in the cycle but we're kinda stuck on this one, I apologize for that... I know this hasn't quite stuck on Nightly yet but I'd like to request this now instead of waiting)

The legal and privacy copy for Pioneer will not be ready by the Firefox 80 release, which means we cannot test it with any real users in 80 unless we can deliver the content remotely.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This code only runs if users type about:pioneer into Firefox, as it's not linked to from anywhere.
  • String changes made/needed: None
Flags: needinfo?(rhelmer)
Attachment #9169703 - Flags: approval-mozilla-beta?

Comment on attachment 9169703 [details]
Bug 1658829 - make all about:pioneer content available off-train r?sfoster

we already built a release candidate for 80

Attachment #9169703 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afec02f44dc1
make all about:pioneer content available off-train r=sfoster,fluent-reviewers,flod

https://hg.mozilla.org/mozilla-central/rev/afec02f44dc1

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Comment on attachment 9169703 [details]
Bug 1658829 - make all about:pioneer content available off-train r?sfoster

approved for 80.0.1

Attachment #9169703 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.