1659066 - Build failures on aarch64-apple-darwin builds because of the discrepancy between rust and clang target name

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

3 crates are causing problems: cc, bindgen and coreaudio-sys.
For two of them, I opened an issue:

• https://github.com/rust-lang/rust-bindgen/issues/1871
• https://github.com/alexcrichton/cc-rs/issues/542

For coreaudio-sys, I'm waiting for https://github.com/rust-lang/rust-bindgen/pull/1872 to be merged and released before submitting a PR to remove the explicit --target it adds because of that.

In any case, there's actually a work around we can apply to avoid the issues entirely, half of which is something we should do anyways on all builds, but needs some extra care.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1659066 - Move base C/C++ compiler flags for cc-rs to CFLAGS_*/CXXFLAGS_.

We are already figuring these flags out via configure for our own C/C++
need, and we should use those instead.

See https://github.com/alexcrichton/cc-rs/issues/371 for how it has
caused us problems in the past.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1659066 - Always pass --target=arm64-apple-darwin to the compiler on arm64 macOS builds.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1659066 - Update glslopt-rs to 0.1.6.

This is a placeholder until those changes are in a release.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdecbe65a90e
Update glslopt-rs to 0.1.6. r=jnicol
https://hg.mozilla.org/integration/autoland/rev/0d9c38d87d51
Move base C/C++ compiler flags for cc-rs to CFLAGS_*/CXXFLAGS_. r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/e8fdf9f3a551
Always pass --target=arm64-apple-darwin to the compiler on arm64 macOS builds. r=froydnj

Comment 5

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=KYgLO8wrRaSLg4fJc9rloQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=e8fdf9f3a551db508bd8dc96d65d4ce355bef36c&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313752343&repo=autoland&lineNumber=171

Backout: https://hg.mozilla.org/integration/autoland/rev/4bc3301b5222b9336943370e29657bcfb98736ab

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be04555a1ba5
Update glslopt-rs to 0.1.6. r=jnicol

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3258419d1c71
Move base C/C++ compiler flags for cc-rs to CFLAGS_*/CXXFLAGS_. r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/2dc4df2ea8d9
Always pass --target=arm64-apple-darwin to the compiler on arm64 macOS builds. r=froydnj

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/be04555a1ba5
https://hg.mozilla.org/mozilla-central/rev/3258419d1c71
https://hg.mozilla.org/mozilla-central/rev/2dc4df2ea8d9