1663841 - Failure to compile on Windows debug

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Jean-Yves Avenard [:jya]]

Didn't pull from central in 2 weeks following PTO.

It no longer build for me.

 0:29.17   = note: lld-link: error: undefined symbol: __declspec(dllimport) _CrtDbgReport
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:716
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(bool __cdecl lower_precision(struct exec_list *))
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:716
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(bool __cdecl lower_precision(struct exec_list *))
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:187
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(public: static void __cdecl `anonymous namespace'::find_lowerable_rvalues_visitor::stack_enter(class ir_instruction *, void *))
 0:29.17           >>> referenced 15 more times
 0:29.17           lld-link: error: undefined symbol: __declspec(dllimport) _invalid_parameter
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:716
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(bool __cdecl lower_precision(struct exec_list *))
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:716
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(bool __cdecl lower_precision(struct exec_list *))
 0:29.17           >>> referenced by C:\Users\jyavenard\Work\Mozilla\gecko\third_party\rust\glslopt\glsl-optimizer\src\compiler\glsl\lower_precision.cpp:187
 0:29.17           >>>               libglslopt-5e51d66771817707.rlib(lower_precision.o):(public: static void __cdecl `anonymous namespace'::find_lowerable_rvalues_visitor::stack_enter(class ir_instruction *, void *))
 0:29.17           >>> referenced 15 more times

Reverting bug 1661045 and bug 1659066, allows to compile

Comment 1

[Jamie Nicol [:jnicol]]

I would guess this is from bug 1659066 rather than 1661045. Mike, is there an additional thing we need to #define in glslopt's build.rs to prevent it try to link to these symbols, or an additional library we need to add to find them?

Comment 2

[Mike Hommey [:glandium]]

I don't reproduce. What's your mozconfig?

Comment 3

[Jean-Yves Avenard [:jya]]

(In reply to Jamie Nicol [:jnicol] from comment #1)

I would guess this is from bug 1659066 rather than 1661045. Mike, is there an additional thing we need to #define in glslopt's build.rs to prevent it try to link to these symbols, or an additional library we need to add to find them?

No, I was getting the linkage error with just 1661045 reverted.

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to Mike Hommey [:glandium] from comment #2)

I don't reproduce. What's your mozconfig?

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-ff-dbg

ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32

ac_add_options --enable-debug
ac_add_options --enable-debug-symbols
ac_add_options --enable-eme=widevine
ac_add_options --enable-rust-debug

#disable jemalloc for debugging memory overwrite
ac_add_options --disable-jemalloc

ac_add_options --disable-launcher-process
ac_add_options --disable-sandbox

#remove if too slow
ac_add_options --disable-optimize

mk_add_options 'export CARGO_INCREMENTAL=1'

ac_add_options --with-ccache=c:/Users/jyavenard/.mozbuild/sccache/sccache.exe

Comment 5

[Mike Hommey [:glandium]]

I still can't reproduce. Try with SCCACHE_RECACHE=1, or disabling sccache.

Comment 6

[Jean-Yves Avenard [:jya]]

I use VS 2017 if that's something that matters.

Comment 7

[Jean-Yves Avenard [:jya]]

(In reply to Mike Hommey [:glandium] from comment #5)

I still can't reproduce. Try with SCCACHE_RECACHE=1, or disabling sccache.

Nope.

Still the same linkage error :(

VS2017, ./mach bootstrap made as of this morning.
tried both with SCCACHE_RECACHE=1 and removing sccache config from mozbuild

I see that the bug with VS2019 has now been fixed, I may just revert to that instead.

Comment 8

[Jean-Yves Avenard [:jya]]

Installed VS2019, tried again. and same error :(

Comment 9

[Jean-Yves Avenard [:jya]]

Attachment: build.log

Full log after clearing sccache , uninstalling VS2017, installing VS2019, deleted ~/.rustup ~/.mozbuild ~/.cargo

line 2608 is the linkage error.

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: mozconfig

Comment 11

[(Away)]

0:28.68 checking rustc version... 1.46.0

CI is currently using 1.43.0, can you try that?

Comment 12

[Jean-Yves Avenard [:jya]]

Ok, I can confirm that the line causing the issue is:
ac_add_options --disable-optimize

Commenting this one and it compiles.

Comment 13

[Jean-Yves Avenard [:jya]]

(In reply to :dmajor from comment #11)

0:28.68 checking rustc version... 1.46.0

CI is currently using 1.43.0, can you try that?

this didn't help.

0:59.99 js/src> checking for rustc... c:/Users/jyavenard/.cargo/bin/rustc.exe
0:60.00 js/src> checking for cargo... c:/Users/jyavenard/.cargo/bin/cargo.exe
1:00.07 js/src> Actually using 'C:\Users\jyavenard.rustup\toolchains\1.43.0-x86_64-pc-windows-msvc\bin\rustc.exe'
1:00.16 js/src> Actually using 'C:\Users\jyavenard.rustup\toolchains\1.43.0-x86_64-pc-windows-msvc\bin\cargo.exe'
1:00.18 js/src> checking rustc version... 1.43.0
1:00.20 js/src> checking cargo version... 1.43.0

I can only compile if the option ac_add_options --disable-optimize isn't used.

Comment 14

[Jean-Yves Avenard [:jya]]

looks like I also need to remove ac_add_options --disable-jemalloc

It's weird, because I got a compilation success with this one once. Or maybe I just didn't fully clobber between two builds.

Anyhow, after dozens of clobber/build

the issue is with ac_add_options --enable-rust-debug

I don't know if this is still necessary for debugging rust code from C++. for now I can remove that

Comment 15

[Mike Hommey [:glandium]]

We have no-opt builds now on automation, so I suppose this is not a problem anymore.