1659118 - Collapsing of bubbles is broken

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

I noticed on TB 80.0b2 that collapsing of Bubbles seems to be broken.

I'm guessing this is related to bug 1646611 or bug 1649788.

Comment 1

[Magnus Melin [:mkmelin]]

Can you provide a screenshot or explanation? I don't understand what this is about.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Screenshot of problem

When there are many system messages in a row they are supposed to be collapsed automatically with a little "+" on the side to expand to view them all. This is no longer happening.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Screenshot of how it should look

Comment 4

[Martin Giger [:freaktechnik]]

MozRegression reduces it to https://hg.mozilla.org/comm-central/pushloghtml?fromchange=01493100c9942ad2b920f7740ba609427e2b5695&tochange=ae90541a3ecd8dc02aafcb15fb74ad592c6332e4 which would make bug 1646611 the prime candidate. I think using a document fragment leads to the inline script tags being pacified. I think the best solution would to make them proper script files that get loaded, if that's a possibility.

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1659118 - Fix chat theme inline scripts not running. r=clokep

Comment 6

[Martin Giger [:freaktechnik]]

Attachment: Bug 1659118 - Fix collapse styles for mail chat theme. r=aleca

Depends on D112735

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1659118 - Tests for chat message collapsing. r=clokep

Depends on D112736

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8aa8b6a40e2d
Fix chat theme inline scripts not running. r=clokep
https://hg.mozilla.org/comm-central/rev/be7cda2645ca
Fix collapse styles for mail chat theme. r=aleca
https://hg.mozilla.org/comm-central/rev/87326da35a5d
Tests for chat message collapsing. r=clokep

Comment 9

[Martin Giger [:freaktechnik]]

Comment on attachment 9217063 [details]
Bug 1659118 - Tests for chat message collapsing. r=clokep

[Approval Request Comment]
Regression caused by (bug #): bug 1646611
User impact if declined: System notices in chat stack up instead of compressing. The CSS issue is already in release, while the JS part is not.
Testing completed (on c-c, etc.): Manual testing of the patch, recently landed in c-c; there is an automated test, but too early to assess its reliability.
Risk to taking this patch (and alternatives if risky): Worst case this breaks display of chat messages, however I'd categorize that as rather unlikely. This patch and the second in the stack are fairly simple and are the only ones that should be uplifted. The second in the stack is only CSS changes for the "mail" theme.

Comment 10

[Martin Giger [:freaktechnik]]

And I of course set the flag on the one patch that doesn't need uplifting.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9217063 [details]
Bug 1659118 - Tests for chat message collapsing. r=clokep

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 89.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/29bcd4d57272
https://hg.mozilla.org/releases/comm-beta/rev/d942cd5b1a14
https://hg.mozilla.org/releases/comm-beta/rev/1e91f14ef6cb