1659203 - Duplicate search mode when duplicating tabs

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Drew Willcoxon :adw]

This was raised by QA, and I asked Verdi, and he says search mode should be duplicated when tabs are duplicated.

Comment 1

[Marco Bonardo [:mak]]

Drew I'm tentatively assigning this to you since it's related to your session restore work.

Comment 2

[Drew Willcoxon :adw]

Bug 1655486 fixed this since tab duplication goes through session store (SessionStore.duplicateTab), but it might be good to have a test for it, so I'll work on that here.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1659203 - Add a test to make sure search mode is duplicated when duplicating tabs.

Whoops, wrong bug number

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7113d5043baca2f8b04cd586c56cd65c855e494

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ed590e517be3df161ca4b4b681e3185bb90f122

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71219cd9e627
Add a test to make sure search mode is duplicated when duplicating tabs. r=harry

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/71219cd9e627

Comment 8

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I tested this on 83.0a1 (2020-10-14) (64-bit) and verified that the @engine is now copied.

Regards, Flor.