1659218 - <input disabled> incorrectly responds to dispatchEvent()

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Kagami :saschanaz]

<input disabled> must not respond to dispatchEvent(new MouseEvent("click")) unless they are checkboxes or radio buttons, but they do.

Comment 1

[Kagami :saschanaz]

Attachment: Bug 1659218 - Prevent activating disabled inputs via dispatchEvent r=smaug

Depends on D87022

Comment 2

[Kagami :saschanaz]

Attachment: bug1659218-radio-morph.html

Context: https://phabricator.services.mozilla.com/D87151#inline-498464

The type changing behavior differs between Firefox and Chrome. On Firefox the original radio button does remain checked, while on Chrome the target input remains checked even when it's not a radio button anymore, with .checked === true.

The spec currently seems to support Chrome one, as it requires the legacy cancelation behavior only if its current type is radio button.

Should I file a spec issue, or should we follow Chrome behavior? My personal preference is the current Firefox behavior, though.

Comment 3

[Olli Pettay [:smaug] [away July 4-8]]

Hmm, Chrome's behavior feels odd. Can you think of reason for that?

Comment 4

[Kagami :saschanaz]

No reason I can think of. Probably a new spec issue?

Comment 5

[Olli Pettay [:smaug] [away July 4-8]]

yeah. I think keeping checked==true feels a bit odd.

Comment 6

[Kagami :saschanaz]

Filed https://github.com/whatwg/html/issues/5904

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0a950708a15
Prevent activating disabled inputs via dispatchEvent r=smaug

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26302 for changes under testing/web-platform/tests

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c0a950708a15

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot