1774035 - Do not open popup from <input disabled type=color/file>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

data:text/html,<input disabled type=file id=input><button onclick="input.dispatchEvent(new MouseEvent('click'))">Button</button>

Per the spec the only exceptions that can activate in a disabled state are checkboxes and radio buttons. Anything else must not trigger the activation behavior.

Interestingly .click() does not open the popup, not sure the difference. (Edit: Ah yes, .click() is an absolute no-op if disabled, for sure)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

https://searchfox.org/mozilla-central/rev/28ed523a3ed5dbf5f6b008cf1e28a9e8a8597b5e/toolkit/content/widgets/datetimebox.js#735 doesn't check for this, neither does https://searchfox.org/mozilla-central/rev/28ed523a3ed5dbf5f6b008cf1e28a9e8a8597b5e/dom/html/HTMLInputElement.cpp#3498

Probably an IsMutable() check is easy enough there?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1774035 - Stop opening pickers from disabled input elements r=smaug

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Filed https://github.com/w3c/webdriver/issues/1666 for WebDriver.

TIL IsMutable(), I wonder I should use it here instead? https://searchfox.org/mozilla-central/rev/28ed523a3ed5dbf5f6b008cf1e28a9e8a8597b5e/dom/html/HTMLInputElement.cpp#3657

Comment 4

[Emilio Cobos Álvarez [:emilio]]

IsMutable is what we use on showPicker, so it seems reasonable to be consistent?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Yeah, but showPicker is solely about pickers and click-to-open is about activation behavior. Somehow color/file are only things that have click-to-open as activation behavior (so that .click() will show the picker) while others like date does not. It's already inconsistent in that sense.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84317cf0446c
Stop opening pickers from disabled input elements r=smaug,emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34430 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

Backed out for causing crashes at mozilla::dom::HTMLInputElement.

Backout link: https://hg.mozilla.org/integration/autoland/rev/de09053e6ede0b98e5b7865b904221c9b80ea520

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=84317cf0446c44a0409f74f243502a3e53facb60&selectedTaskRun=Y3vOwIiDR22iMGpxXe4jwA.0

Failure log:

• https://treeherder.mozilla.org/logviewer?job_id=381287361&repo=autoland&lineNumber=1938
• https://treeherder.mozilla.org/logviewer?job_id=381288579&repo=autoland&lineNumber=11762

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Ah, the assertion should be in each type block instead.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7603664ef19
Stop opening pickers from disabled input elements r=smaug,emilio

Comment 12

[Cristian Tuns]

Backed out for causing multiple failures on spelling-markers-009.html and HTMLInputElement.cpp

• Backout link
• Push with failures
• Failure Log1
• Failure Log2
• Failure Log3

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Cristian Tuns]

And also can you please take a look at those reftest failures: https://treeherder.mozilla.org/logviewer?job_id=381304093&repo=autoland(In reply to Cristian Tuns from comment #12)

Backed out for causing multiple failures on spelling-markers-009.html and HTMLInputElement.cpp

• Backout link
• Push with failures
• Failure Log1
• Failure Log2
• Failure Log3

Comment 15

[Kagami Rosylight [:saschanaz] (they/them)]

The second push was without my fix, sorry for the noise. https://treeherder.mozilla.org/jobs?repo=try&revision=c770f79b279f35df188bb7340756a8d4153fca83

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07af30efd194
Stop opening pickers from disabled input elements r=smaug,emilio

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/07af30efd194

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot