Closed Bug 1659318 Opened 3 months ago Closed 2 months ago

Some items on help menu in {compose, addressbook} window not working

Categories

(Thunderbird :: Message Compose Window, defect)

defect

Tracking

(thunderbird_esr68 affected, thunderbird_esr78 fixed, thunderbird80 affected)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr68 --- affected
thunderbird_esr78 --- fixed
thunderbird80 --- affected

People

(Reporter: public, Assigned: khushil324)

References

(Blocks 1 open bug)

Details

(Whiteboard: smoketestb78.2.0-pre)

Attachments

(1 file, 1 obsolete file)

The compose menu bar contains a 'help' section that is mostly dead, at least with TB 78.2.0-pre on Linux x64. I'd propose to simply remove the whole menu: although some entries work they are not really related to the compose window.

(Not certain if regression: all versions I have are affected)

STR:
0. Make sure you have an email account

  1. Start composing a message
  2. Click on "Help" in the menu bar and then select one of the options

Expected:
No errors are logged and something visible happens

Actual:
Opening the menu throws an exception in utilityOverlay.js:415:35:

Uncaught TypeError: document.getElementById(...) is null
    buildHelpMenu chrome://communicator/content/utilityOverlay.js:415
    onpopupshowing chrome://messenger/content/messengercompose/messengercompose.xhtml:1

For the following menu entries, nothing happens (except errors being logged):

  • Thunderbird Tour
  • Keyboard Shortcuts
  • Get Involved
  • Make a Donation
  • Troubleshooting Information

Other menu entries cause the expected action.

The very same issue also exists in the address book window; I won't file a separate bug as it is very likely that the two issues can get fixed together – although the address book window is a different bugzilla component.

Summary: Dead help menu in compose window → Dead help menu in {compose, addressbook} window
Summary: Dead help menu in {compose, addressbook} window → Some items on help menu in {compose, addressbook} window not working

We should just make these items work, and have the menu consistent.

Assignee: nobody → khushil324
Attachment #9170257 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9170257 [details] [diff] [review]
Bug-1659318_fix-help-menu-0.patch

Review of attachment 9170257 [details] [diff] [review]:
-----------------------------------------------------------------

Personally, I would just remove the non-functional menu items. There is no need for all this stuff which is already on the main window.

::: mail/base/content/mailCore.js
@@ +731,5 @@
>   * Opens the Troubleshooting page in a new tab.
>   */
>  function openAboutSupport() {
> +  let mailWindow = Services.wm.getMostRecentWindow("mail:3pane");
> +  let tabmail = mailWindow.document.getElementById("tabmail");

You know that you can close the last 3pane window and leave a compose window open?
Attachment #9170257 - Flags: review-

In fact, you can start TB from the command line with a compose window only, or on Windows "Send to > Mail recipient" may start without a main window. On Mac you can easily close the last 3pane windows without even closing the application.

(In reply to Jorg K (CEST = GMT+2) from comment #4)

You know that you can close the last 3pane window and leave a compose window
open?

Ohh, I didn't know this!
We can do this then: https://searchfox.org/comm-central/source/mail/base/content/aboutDialog.js#107

Attachment #9170257 - Attachment is obsolete: true
Attachment #9170257 - Flags: review?(mkmelin+mozilla)
Attachment #9170271 - Flags: review?(mkmelin+mozilla)

(In reply to Jorg K (CEST = GMT+2) from comment #4)

Personally, I would just remove the non-functional menu items. There is no
need for all this stuff which is already on the main window...
You know that you can close the last 3pane window and leave a compose window
open?

If you read those two sentences together, you'll know why we must not remove these functions from the help menu of composition!

Comment on attachment 9170271 [details] [diff] [review]
Bug-1659318_fix-help-menu-1.patch

Review of attachment 9170271 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. r=mkmelin
Attachment #9170271 - Flags: review?(mkmelin+mozilla) → review+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e5cda005037b
Fix help menu in the message compose window and addressbook. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

Comment on attachment 9170271 [details] [diff] [review]
Bug-1659318_fix-help-menu-1.patch

[Approval Request Comment]
User impact if declined: non-working help menu items in the affected windows
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): can't get a lot worse

Attachment #9170271 - Flags: approval-comm-esr78?

Comment on attachment 9170271 [details] [diff] [review]
Bug-1659318_fix-help-menu-1.patch

[Triage Comment]
Approved for esr78

Attachment #9170271 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.