1659323 - vCard 2.1 attachment parsing broken

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: reproduction.eml

Emails with attached vCards generated by earlier Thunderbird versions are not parsed correctly in Thunderbird 78.2.0-pre build 1, at least on Linux x64. Due to bug 583572 the attachment is thus invisible unless either "Display Attachments Inline" is disabled or the email is displayed as plain text.

STR:
0. Make sure that "Menu bar | View | Message Body As" is "Original HTML" and that "Menu bar | View | Display Attachments Inline" is checked (default on clean profile)

1. Open the attached eml file

Expected:
The mail contains an attachment, displayed inline

Actual:
The mail does not seem to contain an attachment, error console logs

uncaught exception: ParserError: Invalid parameters in 'email;internet:[e-mail]'

Comment 1

[Jorg K (CEST = GMT+2)]

Regressed by bug 1639430?

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1659323 - Correctly handle "email;internet:" when parsing vCard 2.1. r?mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

The code for dealing with v2.1 cards didn't remove the ;internet part, which is useless information anyway. It also didn't account for version:2.1 being lower-case, which it really should've.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d170d02c657a
Correctly handle "email;internet:" when parsing vCard 2.1. r=mkmelin

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9170266 [details]
Bug 1659323 - Correctly handle "email;internet:" when parsing vCard 2.1. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/c12a0e3968cb

Comment 7

[aa4]

First of all, I am sorry for my English, but I think the problem is still not solved.
My condition is:
Thunderbird 78.2.2 on Windows 7
Menu: View-> Show attachments inline
Menu: View-> Message body as-> Original HTML

When I receive a message containing vCard attached, by selecting the message in the error console I find myself:
uncaught exception: ParserError: Invalid parameters in 'adr; dom: ;;; MyCity'

I understood the problem is in the "; dom" part of the whole string above, but I don't know how to fix it.

It is also no longer possible to modify the vCard: the changes made are discarded when Thunderbird is reopened.

Sincerely thank you for the work you are doing

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to aa4 from comment #7)
If you have a case where it's not working, please file a new bug, and attach a test case (as .eml)