1659380 - Calendar New Event window should start with the title highlighted

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect, P2)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1656693 +++

Bug 1656693 changed the focus, but didn't select the "New Event" text in the dialog, so that the use can just start typing in the title - like on 68.

Alternatively, and I think maybe this would be my preference, we should instead do this using a placeholder - I which would be more modern + the title of the new event needs to be something real for the event to be useful ( you don't want "New Event" in your calendar ever.

I notice it's also possible to save with no title at all entered which will create a "null" event. Let's fix that in this bug as well.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

Comment 3

[BernieStn]

I just noticed a different behavior (when I look at the binaries of Thunderbird in C:\Program Files\Mozilla Thunderbird, I see the version 78.2.0.7538 and file dates from just half an hour ago. Thunderbird seems to have updated.). When I now create a new calendar event, the cursor blinks in the text box near "Title". Basically, that is better than before, but this text box still contains the entry "Neuer Termin".
It would be an acceptable solution if the "Neuer Termin" text would be selected. But the cursor position is right after the "n" of "Termin". So I have to first delete the "Neuer Termin", then I can start entering my event text.
I know that this bug is still in state open, but I wonder where this different behavior comes from. Was it fixed with another bug which deals in the same area?

Comment 4

[Paul Morris [:pmorris]]

Comment on attachment 9172507 [details] [diff] [review]
Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

Review of attachment 9172507 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and works as expected when I tested it.  A few small things to address.

::: calendar/base/content/calendar-editable-item.js
@@ +190,4 @@
>          true
>        );
>  
> +      this.eventNameTextbox.placeholder = cal.l10n.getCalString("newEvent");

Hm, would it work to put this in line in the parseXULToFragment string? Like:

<html:input class="calendar-event-details-core title-desc"
                     placeholder="${cal.l10n.getCalString('newEvent')}"

If so, let's do that instead.

::: calendar/base/content/calendar-month-view.js
@@ +343,5 @@
>          true
>        );
>  
> +      this.querySelector(".calendar-event-name-textbox").placeholder = cal.l10n.getCalString(
> +        "newEvent"

Same here, can this be in line in the parseXULToFragment string instead?

::: calendar/base/content/calendar-multiday-view.js
@@ +327,5 @@
>        this.style.pointerEvents = "auto";
>        this.setAttribute("tooltip", "itemTooltip");
>  
> +      this.querySelector(".calendar-event-name-textbox").placeholder = cal.l10n.getCalString(
> +        "newEvent"

Same thought here.

::: calendar/lightning/content/lightning-item-iframe.js
@@ +363,2 @@
>  
>    // new items should have a non-empty title.

A comment to update.

@@ +363,3 @@
>  
>    // new items should have a non-empty title.
>    if (item.isMutable && (!item.title || item.title.length <= 0)) {

We always want a placeholder for editable items, so now this should just be:
if (item.isMutable) {

Comment 5

[WaltS48 [:walts48]]

(In reply to b3_web from comment #3)

I just noticed a different behavior (when I look at the binaries of Thunderbird in C:\Program Files\Mozilla Thunderbird, I see the version 78.2.0.7538 and file dates from just half an hour ago. Thunderbird seems to have updated.). When I now create a new calendar event, the cursor blinks in the text box near "Title". Basically, that is better than before, but this text box still contains the entry "Neuer Termin".
It would be an acceptable solution if the "Neuer Termin" text would be selected. But the cursor position is right after the "n" of "Termin". So I have to first delete the "Neuer Termin", then I can start entering my event text.
I know that this bug is still in state open, but I wonder where this different behavior comes from. Was it fixed with another bug which deals in the same area?

Yes it was fixed in bug 1656693.

There are several workarounds.

Select the Calendar in the event creation dialog.
Press the Tab key twice.
That highlights the "Neuer Termin" like it worked before.
Start typing.

Select "Neuer Termin" and double click the left mouse button.
Start typing.

Right click in the Title field.
Choose "Select All"
Start typing.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=915b2d39ce689e6999af6cd4391077bec3fc9ec4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1e2ed2e91d3e
Calendar New Event window should start with the title highlighted. r=pmorris DONTBUILD

Comment 8

[Khushil Mistry [:khushil324]]

When should we add ESR uplift request for this?

Comment 9

[Khushil Mistry [:khushil324]]

Comment on attachment 9172855 [details] [diff] [review]
Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

[Approval Request Comment]
Regression caused by (bug #): 1569562
User impact if declined: Title editing in the edit event dialog functionality will be affected UX wise.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9172855 [details] [diff] [review]
Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/6e1dfa49b264

Comment 12

[WaltS48 [:walts48]]

In testing of the 81.0b3 release candidate on Ubuntu 18.04.

I would not say the title is highlighted like the words "New Event" were in version 68.
More like the cursor is placed at the beginning of the field ready for the user to begin typing, and "New Event" is in a light grey font.

Which works fine for me.

Comment 13

[BernieStn]

@WaltS48: You write that the title is not highlighted, and the cursor is placed a the beginning of the field ready for the user to begin typing.
Does that mean that the light grey text "New Event" disappears as soon as the user starts entering? That would be the desired behavior.
But if the cursor is placed at the beginning of the field and "New Event" would be shifted with every key that the user enters, then this would not be the desired behavior. I think it should be in a way that the user can immediately start typing a new event title without having to select or delete the "New Event" text first.

Comment 14

[Magnus Melin [:mkmelin]]

Yes it's using a placeholder now, so the cursor is at the start because there is no "real" input. Working like it should.

like I mentioned in comment 0 we should prevent "null" events - which was not fixed, and now quite a lot more easy to hit. Filed bug 1663303.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9172855 [details] [diff] [review]
Bug-1659380_Calendar-New-Event-title-highlighted-0.patch

[Triage Comment]
Approved for esr78.

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/94272208c223