1659615 - `mach bootstrap` fails on Windows if Windows Defender has exclusions over multiple drives

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

The details of the failure are as follows:

ValueError: Paths don't have the same drive

  File "c:\src\moz\gecko\python/mozboot/mozboot/mach_commands.py", line 45, in bootstrap
    bootstrapper.bootstrap()
  File "c:\src\moz\gecko\python/mozboot\mozboot\bootstrap.py", line 513, in bootstrap
    self.instance.validate_environment(checkout_root)
  File "c:\src\moz\gecko\python/mozboot\mozboot\mozillabuild.py", line 155, in validate_environment
    if is_windefender_affecting_srcdir(srcdir):
  File "c:\src\moz\gecko\python/mozboot\mozboot\mozillabuild.py", line 129, in is_windefender_affecting_srcdir
    if os.path.commonpath([exclusion_path, srcdir]) == exclusion_path:
  File "c:\mozilla-build\python3\lib\ntpath.py", line 621, in commonpath
    raise ValueError("Paths don't have the same drive")

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1659615 - handle the fact Windows Defender might have exclusions on different disks. r?mhentges

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1655361

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5ba3c028d87
handle the fact Windows Defender might have exclusions on different disks. r=mhentges,froydnj

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e5ba3c028d87