1659710 - Make the OpenPGP manager themeable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We can make the OpenPGP manager themeable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1659710-PGP-manager-themeable.patch

Alessandro is on vacancy, so asking you.

Only the popups (menu and context) aren't themed as this isn't easy, especially for Mac. I'm still in the hope that toolkit fixes this.

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 9170661 [details] [diff] [review]
1659710-PGP-manager-themeable.patch

I cannot say if this makes sense. But if you say this won't cause problems, I trust you that it is correct!

Comment 3

[Richard Marti (:Paenglab)]

It makes the global appearance more consistent when the dialogs have a similar look.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/09e3dadadd5f
Make the OpenPGP manager themeable. r=KaiE

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9170661 [details] [diff] [review]
1659710-PGP-manager-themeable.patch

[Approval Request Comment]
User impact if declined: not themed dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Will take for esr. We're past the last 80 beta

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9170661 [details] [diff] [review]
1659710-PGP-manager-themeable.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/e3ff30240ebd