1659753 - Saving PDF with modified form data not persisting form data

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Brendan Dahl [:bdahl]]

STR:

1. Open PDF with form e.g. (https://www.irs.gov/pub/irs-pdf/f1040.pdf)
2. Fill out some form fields
3. Save the PDF (either ctrl/cmd+s or File->Save Page As)
4. Close PDF
5. Open saved file

Expected:
PDF has modified form data
Actual:
PDF form data is empty

Comment 1

[Brendan Dahl [:bdahl]]

I should note that if you click PDF.js's "Download" button the PDF produced works as expected.

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: Bug 1659753 - pdf.js changes (DO NOT MERGE)

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: Bug 1659753 - Support saving PDF form data when using "Save Page As". r=gijs

Now when Ctrl/Cmd+S or "Save Page As" is used, Firefox will send PDF.js a
message to trigger downloading. This allows PDF.js to generate a new PDF
if there is modified form data that needs to be saved or send back the
unmodified data. Once PDF.js has generated the blob it will send messages
to the PdfjsParent to open the "Save As" dialog.

Adds two tests:

1. Saving a plain PDF without forms.
2. Saving a PDF with modified forms and verifies the new PDF has the form
   data.

Depends on D87674

Comment 4

[Brendan Dahl [:bdahl]]

Do either of you have thoughts on which behavior we want from the download button in pdf.js (save as or open with)?

More context:
The test browser_download_open_with_internal_handler.js is failing after these changes. It looks like we expect the "open with" dialog to be triggered from the pdf.js download button, where as with these changes the "save as" dialog is opened. IIIRC, the open with dialog was used at the time because there wasn't an easy way to trigger the "save as" dialog. I think the "save as" dialog makes more sense now that we're able to enter form data and save it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

I think the Save As dialog makes more sense here.

Comment 6

[:Gijs (he/him)]

I agree that the "save as" dialog makes more sense here. I do want to flag up that some of the flows around opening PDFs in external apps described in the comments in bug 1653807 become harder when we do this, so I wonder if we can come up with a lightweight way of fixing that... still, that doesn't need to happen in this bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c516989687c7
Support saving PDF form data when using "Save Page As". r=Gijs

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c516989687c7

Comment 9

[Cristian Fogel [:cfogel]]

Verified with 81.0b4 on Windows 10, macOS 10.15, Ubuntu 18.