1659850 - Release display when we don't have a surface

Status: RESOLVED INVALID

(GeckoView :: General, enhancement, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

If the app is in the background GeckoView is not visibile, and we shouldn't paint anything or run the compositor at all.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Discussing with :snorp and :csadilek we think we shouldn't keep the Display when we don't have a surface, to make some "display already acquired" crashes go away. I'm morphing this bug to be that since it's related.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659850 - Remove unused mStateSaved.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659850 - Move mSurfaceWrapper to Display.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659850 - Add SurfaceViewWrapper.isValid.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659850 - Only acquire GeckoDisplay when we have a surface.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

The current thinking is that we don't want to do this. We believe the exception in Bug 1651096 is valid, and a-c is unknowingly attaching multiple views to a single session.