81 - Available in EN-US only
Categories
(Firefox :: Pioneer, enhancement, P1)
Tracking
()
People
(Reporter: javaun, Assigned: maxx)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Requirements: Only users running EN-US builds can see the About:Pioneer page
Acceptance criteria:
- Users running EN-US can reach About:Pioneer by typing "about pioneer" into the address bar
- Users running any other locale (i.e. EN-CA, DE-DE) are redirected to the about:blank page and see an error message
Reporter | ||
Comment 1•4 years ago
|
||
I am prescriptive above with using locale EN-US. There may be other implementation means. The point is to be low effort/avoid complexity in v1. EN-US can be defeated (and some non-USA countries run EN-US), but we want to put a reasonable bar up in v1. The experience still requires opt-in, still has a text disclosure.
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]: Legal requirement for 81 launch.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
(In reply to Javaun Moradi [:javaun] from comment #0)
Requirements: Only users running EN-US builds can see the About:Pioneer page
Acceptance criteria:
- Users running EN-US can reach About:Pioneer by typing "about pioneer" into the address bar
- Users running any other locale (i.e. EN-CA, DE-DE) are redirected to the about:blank page and see an error message
Hm, do you want about:blank
or do you want an error message? :) We could make about:pioneer
non-functional and display an error message?
Reporter | ||
Comment 4•4 years ago
•
|
||
Update to requirements. If possible, instead of displaying about:blank, let's display a helpful message to the user.
For users who are not running EN-US Firefox builds, they will see all of the content overwritten on the About Pioneer page and simply see this message:
"Pioneer is currently only open to participants in the US who are 19 or older."
This is a line taken directly from the approved copy that eligible EN-US users will see. For users who see the above message because they are outside EN-US, there should not be any buttons or other functionality on About Pioneer. They cannot enroll.
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
•
|
||
Updated string: "Sorry, Pioneer is currently only open to participants in the US who are 19 or older."
Assignee | ||
Comment 6•4 years ago
|
||
Comment 7•4 years ago
|
||
Maxx, one more update from legal: <snip> "For release, when this goes out, can we drop the part about 19 or older. It's fine here but since we can't age gate on this page, I'd rather not include it for release :slightly_smiling_face: Otherwise, this is awesome. TY everyone!" </snip>
So, can we have it say "Sorry, Pioneer is currently only open to participants in the US."
Assignee | ||
Comment 8•4 years ago
•
|
||
Revised the copy in the patch. Thanks, :marnie!
Comment 9•4 years ago
•
|
||
Comment on attachment 9172447 [details]
Bug 1659862 - Added logic to only show Pioneer study content if the users' locale is set to EN-US r=rhelmer
Beta/Release Uplift Approval Request
- User impact if declined: We cannot launch in Firefox 81 without this; this is a Mozilla Legal requirement
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a simple redirect, from the about:pioneer page, based on locale. It is understood that some users not in the US, but running en-US will slip though. This is acceptable to the Pioneer team and product counsel. No risk to Firefox.
- String changes made/needed: None
Comment 10•4 years ago
|
||
(In reply to Marnie Pasciuto-Wood [:marnie] from comment #9)
- String changes made/needed: None
For RelMan: this patch has a Fluent file, but it's not exposed to localization, so no blocker for uplift.
Comment 11•4 years ago
|
||
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e34b6f91037f Added logic to only show Pioneer study content if the users' locale is set to EN-US r=rhelmer,flod
Comment 12•4 years ago
|
||
bugherder |
Comment 13•4 years ago
|
||
Comment on attachment 9172447 [details]
Bug 1659862 - Added logic to only show Pioneer study content if the users' locale is set to EN-US r=rhelmer
Approved for 81.0b5.
Comment 14•4 years ago
|
||
bugherder uplift |
Comment 15•4 years ago
|
||
Is there any pref or any other method that we should worry about to change a build from other locale (i.e. EN-CA, DE-DE) to en-US?
Assignee | ||
Comment 16•4 years ago
|
||
Not currently.
Note that because the EULA of the core study will have the user to confirm they're in the US, this is more of a best effort road block. In the future, we may revise this to a more informed language filter, but this was a good first-pass, per :rhelmer.
Comment 17•4 years ago
|
||
Is this implemented at the moment? Is there a way to verify that?
Assignee | ||
Comment 18•4 years ago
|
||
It is not. We have a blocking bug to populate the EULA from Remote Settings. To test this current gating logic, see this comment from :flod.
Comment 19•4 years ago
|
||
Verified as fixed on Firefox 81.0b8 and on Firefox 82.0a1 on MacOS 10.15, Windows 10 x64 and on Ubuntu 20.04 x64.
I logged this minor issue (Bug 1664142) while testing on RTL build.
Description
•