1659946 - avoid UI breakage due to missing browser.menu.showCharacterEncoding pref

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1578539 +++

Split off bug 1578539 comment 50 - looks like just a variation of that.

If we, for unclear reasons, end up doing the CustomizableUI.jsm migration, things will break when accessing the browser.menu.showCharacterEncoding pref which thunderbird doesn't have...

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1659946_browser_charpref.patch

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

Review of attachment 9170901 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e340575057a
avoid UI breakage due to missing browser.menu.showCharacterEncoding pref. r=pmorris

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

[Approval Request Comment]
User impact if declined: may end up with blank window. The exact STR are unclear.
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): should be safe

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

[Triage Comment]
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/8eadb4b1f8a3