Closed Bug 1659946 Opened 1 year ago Closed 1 year ago

avoid UI breakage due to missing browser.menu.showCharacterEncoding pref

Categories

(Thunderbird :: General, defect, P1)

Desktop
All
defect

Tracking

(thunderbird_esr68 wontfix, thunderbird_esr78 fixed, thunderbird80 affected, thunderbird81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr68 --- wontfix
thunderbird_esr78 --- fixed
thunderbird80 --- affected
thunderbird81 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1578539 +++

Split off bug 1578539 comment 50 - looks like just a variation of that.

If we, for unclear reasons, end up doing the CustomizableUI.jsm migration, things will break when accessing the browser.menu.showCharacterEncoding pref which thunderbird doesn't have...

Attachment #9170901 - Flags: review?(paul)
Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

Review of attachment 9170901 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #9170901 - Flags: review?(paul) → review+
Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0e340575057a
avoid UI breakage due to missing browser.menu.showCharacterEncoding pref. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

[Approval Request Comment]
User impact if declined: may end up with blank window. The exact STR are unclear.
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): should be safe

Attachment #9170901 - Flags: approval-comm-esr78?

Comment on attachment 9170901 [details] [diff] [review]
bug1659946_browser_charpref.patch

[Triage Comment]
Approved for esr78

Attachment #9170901 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.