1660026 - Move print preview handling code into print.js

Status: RESOLVED FIXED

(Toolkit :: Printing, task, P2)

Description

[Mark Striemer [:mstriemer]]

In the TabDialogBox patch the print preview creation has moved into print.js. We also need to wait to start the preview until we've looked up the available destinations and determined our initial settings.

It no longer makes sense to have the preview handling code in PrintUtils, it should be moved into print.js.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1660026 - Move print preview updating code into print.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10d210c411df
Move print preview updating code into print.js r=sfoster,emalysz

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/10d210c411df

Comment 4

[Jonathan Watt [:jwatt]]

Reminder to request beta uplift.

Comment 5

[Mark Striemer [:mstriemer]]

Comment on attachment 9170968 [details]
Bug 1660026 - Move print preview updating code into print.js

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, but part of a refactoring to improve the print preview stability.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This simply moves code from one file to another.
• String changes made/needed: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9170968 [details]
Bug 1660026 - Move print preview updating code into print.js

Approved for 81.0b2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5001b9789e2b