1660100 - The "Firefox is already running" and "Profile missing" startup error dialogs are suddenly much taller than necessary (and so are various other dialogs)

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Start firefox from the command line, specifying a specific directory to use as a profile:

mkdir /tmp/profile; firefox -no-remote -profile /tmp/profile

2. Repeat step 1, in a second terminal window.
3. Look at the "Firefox is already running" dialog that appears.

EXPECTED RESULTS:
The dialog should be about as tall as its content.

ACTUAL RESULTS:
The dialog is unexpectedly tall, with a bunch of blank space towards the bottom.

I think this regressed relatively recently.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (unnecessary tall dialog), in Nightly 81.0a1 (2020-08-19)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering (screenshot taken in Firefox Release, v79)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Daniel Holbert [:dholbert]]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=069bb8bd2356b4d5738e1cec37bf561c24c0f923&tochange=157db696462d8a98905d0f8697088aa97cb6e08f

Comment 5

[Daniel Holbert [:dholbert]]

Tighter regression range (obtained using mozregression):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9498aff64f062c246ccdec5013236bd03470b609&tochange=003b4ce4b7e1adca10b2d8600e89f7263af1887e

Looks like a regression from bug 1651748 which made some changes to widget/gtk/nsWindow.cpp

stransky, could you take a look?

Comment 6

[Daniel Holbert [:dholbert]]

I've found some easier steps to reproduce -- in particular, you don't need to start two Firefox instances simultaneously:

# First, ensure that the directory "/tmp/foobar123" does not exist. Then, run:
firefox -no-remote -profile /tmp/foobar123

This gives me a "Profile Missing" error dialog (because indeed, /tmp/foobar123 does not exist); and that dialog is awkwardly-tall in today's Nightly, just like the "Firefox is already running" dialog in the attached screenshots.

Also, I'm requesting tracking to ensure this is on release management's radar.
[Tracking Requested - why for this release]: regression in 81 (late in the nightly cycle)

Comment 7

[Daniel Holbert [:dholbert]]

(BTW I'm on Ubuntu 20.04, if this happens to be distro-dependent.)

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Okay, will look at it.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 10

[B.J. Herbison]

Bug 1660500 is another recent case of larger than normal windows.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1660100 [Linux/Gtk] Add CSD decorations size only to windows without system titlebar, r?jhorak

• Revert Bug 1658885 - use Gtk styles to get CSD sizes.
• Add CSD decoration sizes to titlebar-less windows only.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f08caac0e0ab
[Linux/Gtk] Add CSD decorations size only to windows without system titlebar, r=jhorak

Comment 19

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f08caac0e0ab

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 21

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9171907 [details]
Bug 1660100 [Linux/Gtk] Add CSD decorations size only to windows without system titlebar, r?jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Wrong window sizes on Linux/Gtk.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Run Firefox with non-existing profile, i.e.:

firefox -no-remote -profile /tmp/foobar123

and check if the dialog size is OK.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're reverting changes from Bug 1658885 so we will use already tested code.
  We update size restrictions for titlebar-less windows which WebRTC indicator only right now.
  Another titlebar-less window is PIP and it does not use maximal size constraints.
• String changes made/needed:

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171907 [details]
Bug 1660100 [Linux/Gtk] Add CSD decorations size only to windows without system titlebar, r?jhorak

Approved for 81.0b5.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bba6f3edfca7

Comment 25

[Florencia Di Ciocco, NI to vbalducci]

Hi all,
I have verified the following by using the steps provided in comment 6 on Firefox Beta 81.0b2 and 81.0b6 (64-bit) and FF Nightly from 2020-08-19 and today with Ubuntu 18:

On the older version, the warning message had extra blank space.
On the latest version, the warning message had the right size.

Regards, Flor.