1673292 - Crash in [@ nsWindow::UpdateTitlebarTransparencyBitmap]

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P1)

Description

[Asif Youssuff]

Attachment: Screenshot_2020-10-25_22-03-43.png

Crash report: https://crash-stats.mozilla.org/report/index/9c0c4f5c-634e-4669-b24b-9a9360201026

Reason: SIGSEGV /SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so nsWindow::UpdateTitlebarTransparencyBitmap /build/firefox-6gpkMf/firefox-81.0.2+build1/widget/gtk/nsWindow.cpp:5632
1 libxul.so <name omitted> /build/firefox-6gpkMf/firefox-81.0.2+build1/widget/gtk/nsWindow.cpp:6770
2 libgtk-3.so.0 _gtk_marshal_BOOLEAN__BOXED /build/gtk+3.0-2Ut_nl/gtk+3.0-3.18.9/./gtk/gtkmarshalers.c:86
3 libgobject-2.0.so.0 g_closure_invoke /build/glib2.0-xkQkqE/glib2.0-2.48.2/./gobject/gclosure.c:804
4 libgobject-2.0.so.0 signal_emit_unlocked_R /build/glib2.0-xkQkqE/glib2.0-2.48.2/./gobject/gsignal.c:3629
5 libgobject-2.0.so.0 g_signal_emit_valist /build/glib2.0-xkQkqE/glib2.0-2.48.2/./gobject/gsignal.c:3395
6 libgobject-2.0.so.0 g_signal_emit /build/glib2.0-xkQkqE/glib2.0-2.48.2/./gobject/gsignal.c:3441
7 libgtk-3.so.0 gtk_widget_event_internal /build/gtk+3.0-2Ut_nl/gtk+3.0-3.18.9/./gtk/gtkwidget.c:7692
8 libgtk-3.so.0 gtk_main_do_event /build/gtk+3.0-2Ut_nl/gtk+3.0-3.18.9/./gtk/gtkmain.c:1795
9 libgdk-3.so.0 gdk_event_source_dispatch /build/gtk+3.0-2Ut_nl/gtk+3.0-3.18.9/./gdk/x11/gdkeventsource.c:369

I get this error in safe mode, but the issue is worse in normal mode when browser.tabs.drawInTitlebar:true

I get bad graphics offset to the left of unmaximized windows, and at worst, the Firefox consumes all my system memory and X gets killed.

13:57.01 INFO: No more integration revisions, bisection finished.
13:57.01 INFO: Last good revision: 4bce303c45e740a5636fa88edfbbe41b6cd2e35e
13:57.01 INFO: First bad revision: f08caac0e0ab2fbabb80ef10deb2228260336b79
13:57.01 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4bce303c45e740a5636fa88edfbbe41b6cd2e35e&tochange=f08caac0e0ab2fbabb80ef10deb2228260336b79

Comment 1

[Asif Youssuff]

Attachment: about:support

Comment 2

[Asif Youssuff]

[Tracking Requested - why for this release]: Nasty crash bug on LTS versions of Xubuntu at least, not sure what packages exacerbates this issue. All a user has to do is enable tabs in the titlebar and restart Firefox.

Comment 3

[Asif Youssuff]

Martin, it'd be great if you could look at this - it is a released issue in 82 that disables the use of Firefox on older versions of Linux (not sure what package versions cause this issue, but this is a Ubuntu Xenial machine).

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I expect it happens when system titlebar is disabled, right? Can you reproduce it reliably?

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Also is that a recent regression?

Comment 6

[Asif Youssuff]

(In reply to Martin Stránský [:stransky] from comment #4)

I expect it happens when system titlebar is disabled, right? Can you reproduce it reliably?

Yes, and I can reproduce it reliably. It seems to be regressed by 1660100.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Can you reproduce that with Mozilla Firefox 82.0 binary? If so please submit a crash report from 82.0 for it and attach it here. The reports you posted are not linked to Mozilla sources so I can't say for sure where the crash happens.
Thanks.

Comment 8

[Asif Youssuff]

Martin, see these crashes from the Mozilla binary:

bp-b14432aa-7d5e-4957-935c-89fce0201026
bp-c2799632-a0d1-45ab-bfee-43bd20201026
bp-f9bb35ae-543c-46a3-b857-d7a000201026

Two of them are ABRT closes because I saw nothing interesting happening on screen and killed manually. bp-b14432aa-7d5e-4957-935c-89fce0201026 happened after I started Firefox in safe mode after an ABRT close. Firefox crashed itself in that instance.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Thanks. For this bug I'll need crashes with nsWindow::UpdateTitlebarTransparencyBitmap() signature.

The ones you posted with X11error fails with:
X_CreatePixmap: BadAlloc (insufficient resources for operation); 49 requests ago

which doesn't look relevant to this bug.

Comment 10

[Asif Youssuff]

Martin, the big issue I am seeing is not this crash, but rather that Firefox is unusable when the system titlebar is disabled.

If you would prefer, I can close this bug and file a new one regarding that issue - I opened this with a crash report because I thought that it might help locate the issue. As mentioned earlier, I was also able to find a regression range.

Steps to reproduce:

1. Download Xubuntu ISO: http://cdimage.ubuntu.com/xubuntu/releases/16.04/release/
2. Run as a live image (no need to install)
3. Within the VM, download Firefox 82
4. Start downloaded Firefox
5. Disable system titlebar in Firefox

What happens:

Firefox is immediately unusable.

Expected result:

Firefox works, like before bug 1660100.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

I'm afraid Ubuntu 16.04 is completely out of scope, we don't support disabled system titlebar on such systems and frankly I don't have time to look at it right now. I think it's wontfix unless someone else want's to fix that.

I expect the issue is that gtk_render_background_get_clip() is not available on such old systems.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 13

[Asif Youssuff]

Martin, if the disabled system titlebar isn't supported, shouldn't the checkbox be gated somehow? Otherwise it is very easy to end up in a non-working situation. If the buttons appear, it certainly seems "supported" to me, and Ubuntu 16.04 is supported until April of next year.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Fix at Bug 1652220 may help here as we switched to RGBA visual and at Bug 1652220 solid-csd styles on non-compositing desktops without shape masks. Please re-test when Bug 1652220 lands.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.