Closed Bug 1660127 Opened 4 years ago Closed 4 years ago

Add periodic and manual synchronisation to CardDAV

Categories

(MailNews Core :: Address Book, task)

Tracking

(thunderbird_esr78+ fixed, thunderbird81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird81 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

(Whiteboard: [TM:78.3.0])

Attachments

(3 files)

No description provided.
Blocks: 1660129

We're using the magic numbers 101 and 102 in a lot of places now. It'd be better if they were constants.

Depends on D87688

Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a1975b9075bd
Add periodic and manual synchronisation to CardDAV. r=mkmelin
https://hg.mozilla.org/comm-central/rev/43085562cae3
Turn address book type constants into members of nsIAbManager. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

I'm aiming to have the first of these patches land for 78.3 or 78.4, depending on how beta goes. In any case it will be behind a pref for the remainder of the 78 cycle.

The patch contains new strings, but one I can borrow from calendar and the other can just be dropped IMO.

NI'ing myself to make an ESR patch.

Flags: needinfo?(geoff)
Whiteboard: [TM:78.3.0]
Flags: needinfo?(geoff)
Flags: needinfo?(geoff)

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: CardDAV users won't be able to sync with servers.
Testing completed (on c-c, etc.): On beta since 81.0b1.
Risk to taking this patch (and alternatives if risky): This is all preffed-off on ESR. It also has fairly good test coverage.

Flags: needinfo?(geoff)
Attachment #9174848 - Flags: approval-comm-esr78?

This needs bug 1664330 uplifted with it.

Depends on: 1664330

Comment on attachment 9174848 [details] [diff] [review]
1660127-carddav-syncmenu-esr.diff

[Triage Comment]
Approved for esr78

Thanks for the detailed risk assessment

Attachment #9174848 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: