Add periodic and manual synchronisation to CardDAV
Categories
(MailNews Core :: Address Book, task)
Tracking
(thunderbird_esr78+ fixed, thunderbird81 fixed)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
(Whiteboard: [TM:78.3.0])
Attachments
(3 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
32.04 KB,
patch
|
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
We're using the magic numbers 101 and 102 in a lot of places now. It'd be better if they were constants.
Depends on D87688
Assignee | ||
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a1975b9075bd
Add periodic and manual synchronisation to CardDAV. r=mkmelin
https://hg.mozilla.org/comm-central/rev/43085562cae3
Turn address book type constants into members of nsIAbManager. r=mkmelin
Assignee | ||
Comment 5•4 years ago
|
||
I'm aiming to have the first of these patches land for 78.3 or 78.4, depending on how beta goes. In any case it will be behind a pref for the remainder of the 78 cycle.
The patch contains new strings, but one I can borrow from calendar and the other can just be dropped IMO.
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
NI'ing myself to make an ESR patch.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: CardDAV users won't be able to sync with servers.
Testing completed (on c-c, etc.): On beta since 81.0b1.
Risk to taking this patch (and alternatives if risky): This is all preffed-off on ESR. It also has fairly good test coverage.
Comment 9•4 years ago
|
||
Comment on attachment 9174848 [details] [diff] [review]
1660127-carddav-syncmenu-esr.diff
[Triage Comment]
Approved for esr78
Thanks for the detailed risk assessment
Comment 10•4 years ago
|
||
bugherder uplift |
Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/d1a5fd7ed12d
Description
•