thread summary unreadable in dark Theme with Mac
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird81 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird81 | --- | fixed |
People
(Reporter: chris, Assigned: Paenglab)
Details
Attachments
(5 files)
|
68.32 KB,
image/png
|
Details | |
|
55.14 KB,
image/png
|
Details | |
|
1.01 KB,
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
|
4.98 KB,
image/png
|
Details | |
|
5.56 KB,
image/png
|
Details |
screen capture of unreadable thread summary
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0
Steps to reproduce:
MacOS Catalina 10.15.6, system set to dark theme. TBird set to follow system preference.
Actual results:
Thread summaries are unreadable - very light grey text on white background. Individual messages are fine, showing black text on white background.
If I set TBird theme to light, then it works fine. Both thread summary and individual messages show with black text on white background.
Expected results:
thread summary should be same as individual messages - dark text on light background (when dark theme is being used).
|
Reporter | |
Comment 1•4 years ago
|
||
|
|
Reporter | |
Comment 2•4 years ago
|
||
using TBird beta channel 80.0b5
|
||
Comment 3•4 years ago
|
||
THanks for using beta.
Sounds like a theme issue.
Can anyone else reproduce this? (I can't seem to enable themes ATM)
|
|
||
Comment 4•4 years ago
|
||
I'm also concerned whether this affects version 78.
|
||
Comment 5•4 years ago
•
|
||
I was just about to figure out how to file a bug report about this issue!
Only happens when using the Dark Thunderbird theme for me using 80.0b5 on Ubuntu 18.04.5 LTS.
If I switch to the Default or Light theme the summaries appear in the Message pane with the threads collapsed.
That is after I restart so the missing items from the Folder and Thread panes reappear.
The summary properly appears in the Message pane using the TB Dark theme in my 80.0b5 on Windows10.
(In reply to Wayne Mery (:wsmwk) from comment #3)
THanks for using beta.
Sounds like a theme issue.Can anyone else reproduce this? (I can't seem to enable themes ATM)
Seems some of my settings are different. The screen looks different for me, but I don't know why.
|
|
||
Comment 7•4 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #4)
I'm also concerned whether this affects version 78.
Just checked on Ubuntu 18.04.5 LTS and it's okay.
Name Thunderbird
Version 78.1.1
Build ID 20200805003102
Updated to:
Name Thunderbird
Version 78.2.0
Build ID 20200821101218
Still looking good.
|
Assignee | |
Comment 8•4 years ago
|
||
It seems the changes in bug 1620467 from -moz-appearance to appearance changed also something how it is applied. We need now to owersteer https://searchfox.org/mozilla-central/rev/73e4e809df771baeb61635b25f53dfb44e930904/toolkit/themes/linux/global/global.css#29 and https://searchfox.org/mozilla-central/rev/73e4e809df771baeb61635b25f53dfb44e930904/toolkit/themes/osx/global/global.css#23. Windows doesn't have this rule. TB 78 (and the others before) had this -moz-appearance: dialog; too and it worked.
|
||
Comment 9•4 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #3)
Can anyone else reproduce this? (I can't seem to enable themes ATM)
I can reproduce this issue with the dark theme activated .
macOS Mojave
|
||
Comment 10•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 11•4 years ago
|
||
Comment on attachment 9171466 [details] [diff] [review]
1660403-sharedsummary-bg-color.patch
[Approval Request Comment]
User impact if declined: unreadable summaries in multimessage view with dark themes.
Testing completed (on c-c, etc.): on the way to c-c
Risk to taking this patch (and alternatives if risky): low
|
||
Comment 12•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5f28a64eac96
Explicitly set appearance: none; on shared summaries <HTML> so that they would be readabe in dark theme with mac. r=aleca
|
|
||
Comment 13•4 years ago
|
||
This will also fix the same problem on Ubuntu Linux?
|
|
||
Comment 15•4 years ago
|
||
Comment on attachment 9171466 [details] [diff] [review]
1660403-sharedsummary-bg-color.patch
[Triage Comment]
approved for beta
|
||
Comment 16•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 81.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/efc0e0a06099
|
||
Comment 17•4 years ago
|
||
I'm assuming 78 was affected too?
|
|
Assignee | |
Comment 18•4 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #17)
I'm assuming 78 was affected too?
No, it isn't. The cause, bug 1620467, landed on 80.
|
|
||
Comment 19•4 years ago
|
||
Much better in my test of the 81.0b2 release candidate on Linux.
I'll leave it for a Mac user to verify.
|
|
Reporter | |
Comment 20•4 years ago
|
||
looks good on Mac OS Catalina 10.15.6 w TB Beta 81.0b2. Thanks for the fix!!
|
|
||
Updated•4 years ago
|
|
||
Comment 21•4 years ago
|
||
Please compare the problem on Thunderbird 78.8 on Windows 10. I attach two screenshots of a reply window into which I have typed a word. Before taking the screenshot I started Thunderbird in safe mode (though the problem affects normal mode too). The email to which I am replying is from an Ebay seller. Evidently, this is a serious problem.
|
|
||
Comment 22•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
|
||
Comment 23•4 years ago
|
||
Description
•