Get the docshell URIFixup tests working with modern search configuration
Categories
(Core :: DOM: Navigation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
In bug 1619926, we are removing a legacy configuration method for search engines in the search service.
Currently the docshell test_URIFixup*.js tests rely on the legacy version of the configuration. I'm working on porting these to the new configuration code.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Note: the attached patch doesn't work at the moment. It fails to create the search engines because when running from docshell/ we don't have the extension schemas/definitions that are in browser/
I'm not quite sure what to do about this.
We do need to give the search service a configuration, otherwise it aborts initialisation. For the new config, this means supplying WebExtensions, the older config was slightly more lenient.
It might be possible that we could move the extension schema definitions for chrome_settings_overrides to toolkit/, but then we'd have a homepage definition in toolkit/ which wouldn't be quite right - and I don't think it is possible to split the schema (though I haven't tried).
The other options would be to move the fixup tests to toolkit or browser, or adding firefox-appdir = browser to the xpcshell.ini file (this basically passes, though there's still one failure I don't understand in test_URIFixup_info.js).
|
||
Comment 3•4 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #2)
Note: the attached patch doesn't work at the moment. It fails to create the search engines because when running from docshell/ we don't have the extension schemas/definitions that are in browser/
I'm not quite sure what to do about this.
IIRC you might be able to do this by adding firefox-appdir = browser to the xpcshell manifest?
|
||
Comment 4•4 years ago
|
||
Don't use webextensions here, just add the engine directly the same way enterprise policy does.
|
|
Assignee | |
Comment 5•4 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
Don't use webextensions here, just add the engine directly the same way enterprise policy does.
That feels a bit hacky. I don't see why we wouldn't make that available as we need it for toolkit. However it does work for now at least, so I'll land with that to get this unblocked.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a3d16542cb1 Transition the docshell URIFixup tests to work with the modern search engine configuration. r=mak
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•