1660650 - The new UI of pdf viewer is not compatible with dark themes

Status: RESOLVED WORKSFORME

(Firefox :: PDF Viewer, enhancement)

Description

[slanterns.w]

Attachment: Snipaste_2020-08-23_07-22-11.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Open pdf with firefox.

Actual results:

The new UI of pdf viewer does not compatible with dark themes

Expected results:

There is a dark UI of pdf viewer which fits the dark themes of firefox like just like before.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Vachan]

Yes, it would be great if the viewer has a dark mode

Comment 3

[Eddie Carswell]

In my case, the PDF viewer shows up dark in Firefox 84 on Windows, but on Fedora 32 the viewer shows up white in both Firefox 84 release and the latest nightly builds.

Comment 4

[slanterns.w]

I found now we can set pdfjs.viewerCssTheme to 2 to force pdf.js to use dark mode (and 1 for light mode, 0 for auto-detect). But it seems the auto-detect mode still cannot adjust the pdf.js theme according to the browser theme.

Comment 5

[Eldmannen]

I would like dark mode in the PDF reader!

Reading black text on white background at night is dreadful!

Comment 6

[Marco Castelluccio [:marco]]

This is working for me, can anyone still reproduce?

Comment 7

[slanterns.w]

(In reply to Marco Castelluccio [:marco] from comment #6)

This is working for me, can anyone still reproduce?

No, I think there is a dark theme and pdfjs.viewerCssTheme works fine for most situations now.

Comment 8

[Eldmannen]

The UI now for me is dark as expected!

Maybe it would be nice to be able to read a PDF and have it displayed with black text on white background though.

Comment 9

[Eddie Carswell]

While it would be nice for the autodetect feature to work, I pretty much only use dark mode anyway. The about:config preference was a suitable fix for me. Perhaps there could be a toggle added to the pdf.js menu to handle this pref for the less technical users.