Closed Bug 1660706 Opened 4 years ago Closed 4 years ago

Add mochitests to check for modules being loaded too early on startup, and for too many accesses to preferences

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr78 wontfix, thunderbird81 wontfix)

RESOLVED FIXED
82 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird81 --- wontfix

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

There's a couple of performance related mochitests that Firefox has, that I think would be useful for Thunderbird:

  • browser_startup.js - checks that modules/services are not loaded before certain points in the startup process. This aims to help developers adding things unnecessarily early - but rather delaying them until later when they are actually needed.
  • browser_preferences_usage.js - checks various cases to ensure that preferences aren't accessed too frequently. Preference accesses can be expensive, and frequent accesses make that worse.

Bug 1660705 is an example that browser_startup.js has caught, and bug 1660702 is an example that browser_preferences_usage.js has caught.

Whilst these things may not be big in themselves, it all helps to start streamlining the startup process.

Note: the patches I'm attaching are currently still in work. They could do with a few more bugs filing, and I'm also waiting on try server results.

Blocks: 1660876
Blocks: 1660898
Blocks: 1660904
Blocks: 1660907
Attachment #9171597 - Attachment description: Bug 1660706 - Add a mochitest performance test to ensure modules are not loaded too early on startup. → Bug 1660706 - Add a mochitest performance test to ensure modules are not loaded too early on startup. r?mkmelin
Attachment #9171598 - Attachment description: Bug 1660706 - Add test to check for the amount of accesses of preferences on startup. → Bug 1660706 - Add test to check for the amount of accesses of preferences on startup. r?mkmelin

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/comm-central/rev/67e6e75c94c1
Add a mochitest performance test to ensure modules are not loaded too early on startup. r=mkmelin
https://hg.mozilla.org/comm-central/rev/3adb09ecdd2c
Add test to check for the amount of accesses of preferences on startup. r=mkmelin

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Blocks: 1661257
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/comm-central/rev/7071e2e04481
Fix test bustage. Extend allowable pref ranges, workaround xpcshell child process issues.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: