1660773 - Doorhanger: Firefox crashes when trying to print on reddit.com

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Martin Balfanz [:mbalfanz]]

STR:

1. Visit https://www.reddit.com/r/Clojure/
2. Trigger print dialog (doorhanger)
3. Select "Save to PDF" as destination
4. Continue the "Save to PDF" workflow

ER: A PDF document should be created and saved
AR: Firefox crashes, see crash report

Comment 1

[Martin Balfanz [:mbalfanz]]

I can reproduce the same crash using the old dialog (setting print.tab_modal.enabled to false) and choosing "PDF -> Open in Preview" on OS X. On Windows, it seems to work.

Here's the crash report.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Looks like deep in the Cocoa PDF driver :(

Comment 3

[Martin Balfanz [:mbalfanz]]

Mozregression died on me again, but this is how far I got: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=432e42cbbc4139efd2319952ec33efe8ff9add3c&tochange=35cdd8678bbfed2d652deb2d7105494e366f1a0e

Comment 4

[Jonathan Kew [:jfkthame]]

This doesn't crash for me; using the given STR, I successfully created a Clojure.pdf document. I'm currently on macOS 10.15.4 Beta (19E224g), fwiw.

(The resulting PDF does seem to be missing lots of text, though; basically only the titles of the posts show up, not the contents. This seems to be caused by the mask-image that's applied to the post contents. The same issue can be seen in the preview display.)

Comment 5

[Sean Voisen (:svoisen)]

I'm able to reproduce this on 10.15.6 every time. I wonder if there's something different between 10.15.4 and 10.15.6?

Comment 6

[Erik Nordin [:nordzilla]]

I am also able to successfully save to PDF using the given STR. I'm on macOS 10.15.5.

Comment 7

[Sean Voisen (:svoisen)]

Looks like this crashes if you print or save to PDF with Black & White mode.

I remember a crash on macOS a while back when printing with background images enabled somewhere in Core Graphics. I wonder if the filter being applied for B&W is causing similar issues ...

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I've confirmed that the first patch in bug 1660857 fixes this crash (on macOS 10.14.6, FWIW).

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Now bug 1660857 landed, this crash should no longer happen. (Note that the key factor is "not applying filter: grayscale(1)" in printing documents)

Matin or Sean, Can you please double check the crash no longer happens? The latest nightly hasn't yet been available though.

Comment 10

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2020-08-28 at 09.03.50.png

I can confirm that this works for me in the latest Nightly!

I see that the color choice option has been disabled in the settings dialog, which is great.

One remark though: The preview does not update properly on the changed color setting. See the screenshot attached: On the left is a new, fresh profile. On the right is my old (day-to-day) profile. Both run the same Nightly version, and the right one shows a black and white preview (probably because of the previous settings).

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Thank you, Martin!

(In reply to Martin Balfanz [:mbalfanz] from comment #10)

One remark though: The preview does not update properly on the changed color setting. See the screenshot attached: On the left is a new, fresh profile. On the right is my old (day-to-day) profile. Both run the same Nightly version, and the right one shows a black and white preview (probably because of the previous settings).

Filed bug 1661645.

Now this has been fixed by bug 1660857.

Comment 12

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on 83.0a(120200922154306) and 82.0b2(20200922183749). Used a macOS 10.14.6 to test