1661645 - Reset applying grayscale filter when the destination is set to "Save to PDF"

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Hiroyuki Ikezoe (:hiro)]

STR;

1. Open print preview
2. Change color mode to "Black and white" somehow (e.g. changing the destination to a printer which is able to print out in color)
3. Switch the destination to "Save to PDF"

Comment 1

[Martin Balfanz [:mbalfanz]]

Another scenario that I just bumped into with a fresh profile: I have "black and white"-only printer connected. I open the print preview, and while the "color mode" is correct in the settings, the preview shows colors.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

This line is not working as expected: https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/toolkit/components/printing/content/print.js#781

As in, it's not triggering the handleEvent() below....

Comment 3

[Emilio Cobos Álvarez [:emilio]]

https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/dom/html/nsGenericHTMLElement.cpp#2039 (events get marked as trusted automatically by chrome code)

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1661645 - Work around chrome-only automatic-trusted-events in print.js. r=emalysz

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1661645 - Set printInColor based on printer support r?emilio,emalysz

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a85b68ddab4
Set printInColor based on printer support r=emilio,emalysz

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1a85b68ddab4

Comment 9

[Jonathan Watt [:jwatt]]

Reminder to request Beta uplift.

Comment 10

[Mark Striemer [:mstriemer]]

Comment on attachment 9172721 [details]
Bug 1661645 - Set printInColor based on printer support r?emilio,emalysz

Beta/Release Uplift Approval Request

• User impact if declined: Print settings for the color mode can get out of sync.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Feature is behind a pref.
• String changes made/needed: No

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Reproduced this issue using Firefox 82.0a1 (BuildId:20200828153126).

This issue is verified fixed while changing between different printing destinations (physical printers (B&W), Save to PDF, OneNote for Windows 10, Microsoft XPS Document Writer & Fax.)

Please note that Microsoft Print to PDF seems to be affected. But I think that this issue will be tracked in another bug -> see Bug 1661720.

Verified using Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit (with the platform specific destinations).

Leaving a ni? on myself and the qe-verify+ flag until this gets verified in Beta as well.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172721 [details]
Bug 1661645 - Set printInColor based on printer support r?emilio,emalysz

This needs a rebased patch for Beta

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Needs bug 1660857 (see bug 1660857 comment 24).

Comment 14

[Blake Winton (:bwinton) (:☕️)]

Bug 1660857 has been uplifted, we're checking to see if this applies cleanly now…

Comment 15

[Mark Striemer [:mstriemer]]

I just successfully grafted 1a85b68ddab4 onto beta now that bug 1660857 is there.

Do you mind trying again, Ryan?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172721 [details]
Bug 1661645 - Set printInColor based on printer support r?emilio,emalysz

Yes, thanks. Approved for 81.0b6.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e694fcec50b6

Comment 18

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed.

Verified using 83.0a1 (2020-09-22) and Beta 82.0b2 with Win10x64, macOS 10.15.6 and Ubuntu 20