1661045 - Unbreak glslopt build on OpenBSD (affects central & beta)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Landry Breuil (:gaston)]

+++ This bug was initially created as a clone of Bug #1656210 +++

The glsl-optimizer dependency, based on Mesa code but not the Mesa build system, needs a little fix to build on OpenBSD.

cargo:warning=glsl-optimizer/src/util/u_thread.h:83:4: error: use of undeclared identifier 'pthread_set_name_np'; did you mean 'pthread_setname_np'?

Filed https://github.com/jamienicol/glslopt-rs/issues/7 downstream, this bug should track the update of the dep in mozilla-central, then its uplift to mozilla-beta

Comment 1

[Landry Breuil (:gaston)]

[Tracking Requested - why for this release]:

FTBFS on tier3/OpenBSD

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Not tracking since it's a Tier 3 platform, but I'll happily accept an uplift request when the time comes.

Comment 3

[Sotaro Ikeda [:sotaro]]

: jnicol, can you comment to the bug?

Comment 4

[Jamie Nicol [:jnicol]]

Attachment: Bug 1661045 - Update glslopt to fix build on OpenBSD. r?lsalzman

Comment 5

[Jamie Nicol [:jnicol]]

sanity try run to ensure I haven't broken other platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a87561f5b123ef2499a3a17faaa78b42c62551

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ebe7a758b1d
Update glslopt to fix build on OpenBSD. r=lsalzman

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4ebe7a758b1d

Comment 8

[Landry Breuil (:gaston)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

Not tracking since it's a Tier 3 platform, but I'll happily accept an uplift request when the time comes.

i dont know anymore what's the procedure to request an uplift, isnt it setting the tracking flag to ? for firefox81 like before ? or this moved to phabricator ?

Comment 9

[Jamie Nicol [:jnicol]]

(In reply to Landry Breuil (:gaston) from comment #8)

i dont know anymore what's the procedure to request an uplift, isnt it setting the tracking flag to ? for firefox81 like before ? or this moved to phabricator ?

You can click "details" next to the patch in the "attachments" section, then set "approval-mozilla-beta" to "?" and fill out the form. I'll do it now.

I think the distinction with tracking is that as this is tier 3 we don't want it showing up in amongst all the critical bugs that must be fixed and uplifted when Ryan is trying to get the next release in shape.

Comment 10

[Jamie Nicol [:jnicol]]

Comment on attachment 9172113 [details]
Bug 1661045 - Update glslopt to fix build on OpenBSD. r?lsalzman

Beta/Release Uplift Approval Request

• User impact if declined: Broken build on OpenBSD
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor change to ensure a required header is included on OpenBSD in glslopt-rs dependency. We don't test OpenBSD builds in automation, but our testing ensures other platforms weren't broken as a result of the change. Reporter has confirmed that OpenBSD build was fixed in the linked github issue .
• String changes made/needed: N/A

Comment 11

[Landry Breuil (:gaston)]

(In reply to Jamie Nicol [:jnicol] from comment #9)

(In reply to Landry Breuil (:gaston) from comment #8)

i dont know anymore what's the procedure to request an uplift, isnt it setting the tracking flag to ? for firefox81 like before ? or this moved to phabricator ?

You can click "details" next to the patch in the "attachments" section, then set "approval-mozilla-beta" to "?" and fill out the form. I'll do it now.

Doh, right. That shows i havent done much in the past months, i should have remembered that bit.. thanks !

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9172113 [details]
Bug 1661045 - Update glslopt to fix build on OpenBSD. r?lsalzman

approved for 81.0b3

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d613e95d7f4d