1661079 - Make Vector/HashMap in CompilationInfo independent from JSContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

To pass CompilationInfo between threads, containers used there shouldn't use js::TempAllocPolicy, otherwise it will refer JSContext in other thread.
All containers used there should use js::SystemAllocPolicy, and manually report OOM.

This bug will leave CompilationInfo.cx field, given it's easy to workaround it and fixing it later is simpler

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 1: Use SystemAllocPolicy in CompilationInput.atoms. r?tcampbell!

Depends on D88338

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 2: Remove JSContext* parameter from CompilationInput. r?tcampbell!

Depends on D88339

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 3: Use SystemAllocPolicy in CompilationStencil.regExpData. r?tcampbell!

Depends on D88340

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 4: Use SystemAllocPolicy in CompilationStencil.bigIntData. r?tcampbell!

Depends on D88341

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 5: Use SystemAllocPolicy in CompilationStencil.objLiteralData. r?tcampbell!

Depends on D88342

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 6: Use SystemAllocPolicy in CompilationStencil.scriptData. r?tcampbell!

Depends on D88343

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 7: Use SystemAllocPolicy in CompilationStencil.scopeData. r?tcampbell!

Depends on D88344

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 8: Use SystemAllocPolicy in CompilationStencil.asmJS. r?tcampbell!

Depends on D88345

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 9: Use SystemAllocPolicy in StencilModuleMetadata::EntryVector and ModuleBuilder::RequestedModuleVector. r?tcampbell!

Depends on D88346

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 10: Use SystemAllocPolicy in FunctionDeclarationVector. r?tcampbell!

Depends on D88347

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 11: Remove JSContext* parameter from StencilModuleMetadata. r?tcampbell!

Depends on D88348

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 12: Use SystemAllocPolicy in WellKnownParserAtoms.entrySet_ and ParserAtomsTable.entrySet_. r?tcampbell!

Depends on D88349

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 13: Remove JSContext* parameter from WellKnownParserAtoms. r?tcampbell!

Depends on D88350

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 14: Use JSRuntime* parameter in ParserAtomsTable and CompilationStencil. r?tcampbell!

Depends on D88351

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 15: Add warning about CompilationInfo.cx. r?tcampbell!

Depends on D88352

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1661079 - Part 16: Remove JSContext* parameter from ScriptStencil. r?tcampbell!

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2665585f2a5
Part 1: Use SystemAllocPolicy in CompilationInput.atoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/aa42c2318789
Part 2: Remove JSContext* parameter from CompilationInput. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/30bc5659308e
Part 3: Use SystemAllocPolicy in CompilationStencil.regExpData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/52c2d490e6ce
Part 4: Use SystemAllocPolicy in CompilationStencil.bigIntData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9cba1a562dbe
Part 5: Use SystemAllocPolicy in CompilationStencil.objLiteralData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a82c8bd5c573
Part 6: Use SystemAllocPolicy in CompilationStencil.scriptData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8eeee3d8dfdf
Part 7: Use SystemAllocPolicy in CompilationStencil.scopeData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/96c0243b6927
Part 8: Use SystemAllocPolicy in CompilationStencil.asmJS. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6f9637872a7d
Part 9: Use SystemAllocPolicy in StencilModuleMetadata::EntryVector and ModuleBuilder::RequestedModuleVector. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7d83a48e9034
Part 10: Use SystemAllocPolicy in FunctionDeclarationVector. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/39daa05687a9
Part 11: Remove JSContext* parameter from StencilModuleMetadata. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6794706d0c22
Part 12: Use SystemAllocPolicy in WellKnownParserAtoms.entrySet_ and ParserAtomsTable.entrySet_. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/65ac0c614053
Part 13: Remove JSContext* parameter from WellKnownParserAtoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/950686a24954
Part 14: Use JSRuntime* parameter in ParserAtomsTable and CompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d60d7ef431a3
Part 15: Add warning about CompilationInfo.cx. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/3c97bd31c365
Part 16: Remove JSContext* parameter from ScriptStencil. r=tcampbell

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b2665585f2a5
https://hg.mozilla.org/mozilla-central/rev/aa42c2318789
https://hg.mozilla.org/mozilla-central/rev/30bc5659308e
https://hg.mozilla.org/mozilla-central/rev/52c2d490e6ce
https://hg.mozilla.org/mozilla-central/rev/9cba1a562dbe
https://hg.mozilla.org/mozilla-central/rev/a82c8bd5c573
https://hg.mozilla.org/mozilla-central/rev/8eeee3d8dfdf
https://hg.mozilla.org/mozilla-central/rev/96c0243b6927
https://hg.mozilla.org/mozilla-central/rev/6f9637872a7d
https://hg.mozilla.org/mozilla-central/rev/7d83a48e9034
https://hg.mozilla.org/mozilla-central/rev/39daa05687a9
https://hg.mozilla.org/mozilla-central/rev/6794706d0c22
https://hg.mozilla.org/mozilla-central/rev/65ac0c614053
https://hg.mozilla.org/mozilla-central/rev/950686a24954
https://hg.mozilla.org/mozilla-central/rev/d60d7ef431a3
https://hg.mozilla.org/mozilla-central/rev/3c97bd31c365