1661203 - Dark Theme inconsistency with OpenPGP and S/MIME message security window

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas]

Attachment: message security.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36 Edg/84.0.522.63

Steps to reproduce:

Receive e-mails with either OpenPGP or S/MIME encryption or signature. Click the lock or letter icon to open the message security window.

Actual results:

In dark mode, the S/MIME message security window is dark, whereas the corresponding OpenPGP window is light.

Expected results:

Show both windows with the same style in dark mode.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1661203-openPGP-status-themeable.patch

Make it themeable too.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9172092 [details] [diff] [review]
1661203-openPGP-status-themeable.patch

Review of attachment 9172092 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9172092 [details] [diff] [review]
1661203-openPGP-status-themeable.patch

[Approval Request Comment]
User impact if declined: inconsidtent dialog colours with dark themes
Testing completed (on c-c, etc.): on the way to c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9172092 [details] [diff] [review]
1661203-openPGP-status-themeable.patch

[Triage Comment]
approved for beta

Kai or Walt can you test this when the beta becomes available?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42592551aa26
Make the OpenPGP message security status dialog themeable. r=aleca

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 81.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/4acbb1d30f13

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9172092 [details] [diff] [review]
1661203-openPGP-status-themeable.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.2.1:
https://hg.mozilla.org/releases/comm-esr78/rev/c206e51ae18c

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

Is it correct to add both code lines in the patch? The dialogShadowDom.js seems to do exactly the injection of the themeableDialog.css. So why do we need both?

+<?xml-stylesheet href="chrome://messenger/skin/themeableDialog.css" type="text/css"?>

+<script src="chrome://messenger/content/dialogShadowDom.js"/>

Comment 10

[Richard Marti (:Paenglab)]

The dialog buttons, the "OK" button for example, are in shadow DOM where our style sheets have no access, so we need to inject it there through dialogShadowDom.js.

Comment 11

[Alex Ihrig [:Thunderbird_Mail_DE]]

Maybe i haven't seen the complete / latest version of the JS file. If I understand it right, the JS in the file I've seen in DXR, had only the function to inject the CSS.

Comment 12

[Alex Ihrig [:Thunderbird_Mail_DE]]

So this JS provides the ability to style dialog / window elements on the outside of the content:

https://hg.mozilla.org/comm-central/file/tip/mail/base/content/dialogShadowDom.js

Okay ;-)

Comment 13

[Kai Engert [:KaiE:]]

Removing needinfo, I haven't yet played with themes, so I currently don't know how to test this. But it looks like you already solved this.

Comment 14

[WaltS48 [:walts48]]

The OpenPGP dialog looks good in the tests I did on Windows and Linux of the 78.2.1 and 81.0b2 release candidates.