1661270 - Video fullscreen button is broken with iframes

Status: VERIFIED FIXED

(GeckoView :: Media, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

See also: https://github.com/mozilla-mobile/fenix/issues/14003

STR: Navigate to aljazeera.com/live and press the fullscreen button in the video. Nothing happens.

I think this is likely a regression from Bug 1648149.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

From a quick debugging session, it looks like we're not receiving the MozDOMFullscreen:Request event on the child actor. Looking.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1661270 - Actually run ContentDelegate on all frames.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36d7d50f4a37
Actually run ContentDelegate on all frames. r=snorp

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36d7d50f4a37

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 9172203 [details]
Bug 1661270 - Actually run ContentDelegate on all frames.

Beta/Release Uplift Approval Request

• User impact if declined: Pages cannot trigger fullscreen from iframes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The module doesn't currently run in iframes due to a mis-configuration, this change makes the code run on iframes too.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172203 [details]
Bug 1661270 - Actually run ContentDelegate on all frames.

Approved for 81.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/00f23cc5cc56

Comment 9

[Laurentiu Apahidean]

verified as fixed on Nightly 8/31 GV: 82.0a1-2020829091226 with:

OnePlus 6T (Android 9)
Huawei MediaPad M3 (Android 7)

Will come back with results for Firefox Preview Beta

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed on 81.1.0-beta.2 with Google Pixel 3 (Android 11).

Comment 11

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.