Closed Bug 1662327 Opened 4 years ago Closed 4 years ago

Tabs containing an iframe have their title set to that of the iframe

Categories

(GeckoView :: General, defect, P1)

Unspecified
All

Tracking

(firefox80 unaffected, firefox81+ fixed, firefox82+ verified)

VERIFIED FIXED
82 Branch
Tracking Status
firefox80 --- unaffected
firefox81 + fixed
firefox82 + verified

People

(Reporter: liuche, Assigned: agi)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

filed from https://github.com/mozilla-mobile/fenix/issues/14433

Steps to reproduce

Go to a page that embeds an iframe.

Expected behavior

The title of the tab is that of the actual page you're on.

Actual behavior

The title of the page is that of the embedded iframe. For example on Rotten Tomatoes, the title of the page becomes "Disqus Realtime Notification".

Device information

  • Android device: Huawei Nova 6 (Android 10)
  • Fenix version: Nightly 200829 06:05 (Build #2015760755)
    AC: 57.0.20200827190112, 91f7bcbca
    GV: 82.0a1-20200827093043
    AS: 61.0.13
No longer depends on: 1661270
Keywords: regression
Regressed by: 1661270
Has Regression Range: --- → yes
Assignee: nobody → agi
Severity: -- → S3
Priority: -- → P1
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1814c80616f0
Use pagetitlechanged instead of DOMTitleChanged. r=esawin,droeh
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9173534 [details]
Bug 1662327 - Use pagetitlechanged instead of DOMTitleChanged.

Beta/Release Uplift Approval Request

  • User impact if declined: Title for webpages with iframes might be wrong.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Switches GV to use an event used by desktop too for the same purpose.
  • String changes made/needed:
Attachment #9173534 - Flags: approval-mozilla-beta?

QA should verify this on Beta once there's an updated Fenix build with the fix.

Flags: qe-verify+

Comment on attachment 9173534 [details]
Bug 1662327 - Use pagetitlechanged instead of DOMTitleChanged.

Approved for 81.0b6.

Attachment #9173534 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Hi all, sorry if I misunderstand but is this in nightly already? Most sites now have their title set to that of the iframe for a second, after which it changes to the url of the page instead of the title. There are some exceptions to this, for exemple for vimeo videos the title is often set to "Vimeo Player LocalStorage Proxy". Also, if on any page you use ublock's element picker, the title becomes "uBlock Origin Element Picker".

The fix hasn't made it to Firefox Nightly yet, no. They still need to merge the newest GeckoView.

Ah okay, sorry for the confusion!

Verified as fixed on the latest Firefox Nightly build from 9/10 on Samsung Galaxy Tab S6 (Android 9), and HTC 10 (Android 8).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: