Tabs containing an iframe have their title set to that of the iframe
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox80 unaffected, firefox81+ fixed, firefox82+ verified)
Tracking | Status | |
---|---|---|
firefox80 | --- | unaffected |
firefox81 | + | fixed |
firefox82 | + | verified |
People
(Reporter: liuche, Assigned: agi)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
filed from https://github.com/mozilla-mobile/fenix/issues/14433
Steps to reproduce
Go to a page that embeds an iframe.
Expected behavior
The title of the tab is that of the actual page you're on.
Actual behavior
The title of the page is that of the embedded iframe. For example on Rotten Tomatoes, the title of the page becomes "Disqus Realtime Notification".
Device information
- Android device: Huawei Nova 6 (Android 10)
- Fenix version: Nightly 200829 06:05 (Build #2015760755)
AC: 57.0.20200827190112, 91f7bcbca
GV: 82.0a1-20200827093043
AS: 61.0.13
This is fallout from Bug 1661270.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1814c80616f0 Use pagetitlechanged instead of DOMTitleChanged. r=esawin,droeh
Comment 4•4 years ago
|
||
bugherder |
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9173534 [details]
Bug 1662327 - Use pagetitlechanged instead of DOMTitleChanged.
Beta/Release Uplift Approval Request
- User impact if declined: Title for webpages with iframes might be wrong.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Switches GV to use an event used by desktop too for the same purpose.
- String changes made/needed:
Comment 6•4 years ago
|
||
QA should verify this on Beta once there's an updated Fenix build with the fix.
Comment 7•4 years ago
|
||
Comment on attachment 9173534 [details]
Bug 1662327 - Use pagetitlechanged instead of DOMTitleChanged.
Approved for 81.0b6.
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Hi all, sorry if I misunderstand but is this in nightly already? Most sites now have their title set to that of the iframe for a second, after which it changes to the url of the page instead of the title. There are some exceptions to this, for exemple for vimeo videos the title is often set to "Vimeo Player LocalStorage Proxy". Also, if on any page you use ublock's element picker, the title becomes "uBlock Origin Element Picker".
Assignee | ||
Comment 10•4 years ago
|
||
The fix hasn't made it to Firefox Nightly yet, no. They still need to merge the newest GeckoView.
Comment 11•4 years ago
|
||
Ah okay, sorry for the confusion!
Comment 12•4 years ago
|
||
Verified as fixed on the latest Firefox Nightly build from 9/10 on Samsung Galaxy Tab S6 (Android 9), and HTC 10 (Android 8).
Updated•4 years ago
|
Description
•