1661352 - Warp: Transpile FunApplyArray and spread calls

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

Transpiler support for FunApplyArgs was added in bug 1658811. These patches add support for FunApplyArray (and spread calls, which are very similar).

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1661352: Split up GuardFunApplyArray r=jandem

Prior to the NON_PACKED flag, we had to iterate over each element of the array to verify that it was packed. It made sense to fold the argc check in with that code. Now that we are using the flag, I moved the argc check inside the call op to match other argument formats.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1661352: Transpile GuardArrayIsPacked r=jandem

It's a bit awkward having both MIsPackedArray and MGuardArrayIsPacked, but I didn't see a nicer approach.

Depends on D88510

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1661352: Store arg format in CallInfo r=jandem

This makes transpiling nicer, and should also make inlining much easier.

Depends on D88511

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1661352: Transpile FunApplyArray r=jandem

CallInfo::ArgFormat::Array supports FunApplyArray (in this patch), SpreadCall (in the next patch), and eventually SpreadNew/SpreadSuperCall.

Depends on D88512

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1661352: Transpile spread calls r=jandem

The assertion in emitLoadArgumentSlot was unnecessary. Spread calls always have an argc of 1, so hasArgumentArray and !addArgc cancel each other out in GetIndexOfArgument.

Depends on D88513

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9abed09112c4
Split up GuardFunApplyArray r=jandem
https://hg.mozilla.org/integration/autoland/rev/65b269adf362
Transpile GuardArrayIsPacked r=jandem
https://hg.mozilla.org/integration/autoland/rev/732dada7d4a5
Store arg format in CallInfo r=jandem
https://hg.mozilla.org/integration/autoland/rev/9fcedf4aaee2
Transpile FunApplyArray r=jandem
https://hg.mozilla.org/integration/autoland/rev/4cd7a663cfab
Transpile spread calls r=jandem

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9abed09112c4
https://hg.mozilla.org/mozilla-central/rev/65b269adf362
https://hg.mozilla.org/mozilla-central/rev/732dada7d4a5
https://hg.mozilla.org/mozilla-central/rev/9fcedf4aaee2
https://hg.mozilla.org/mozilla-central/rev/4cd7a663cfab