1661388 - Print preview progress dialog appears when window.print is called if print.show_print_progress is true.

Status: VERIFIED FIXED

(Core :: Printing: Setup, defect, P1)

Description

[Hiroyuki Ikezoe (:hiro)]

STR;

1 Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
2 Click the print icon button in the pdf viewer

Comment 1

[Hiroyuki Ikezoe (:hiro)]

The regression range is;
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2969f3de028f013d30ea20bfccc13670ef8e195f&tochange=0c1847dee730f55b184459f5578c67ab45b611c1

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Odd.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661388 - Factor out the default print settings code. r=jwatt

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661388 - Never show the print progress dialog if we're calling window.print() with the new UI. r=jwatt

Depends on D88397

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fc46abf5b83
Factor out the default print settings code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/046111d1aa43
Never show the print progress dialog if we're calling window.print() with the new UI. r=jwatt

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8fc46abf5b83
https://hg.mozilla.org/mozilla-central/rev/046111d1aa43

Comment 7

[Jonathan Watt [:jwatt]]

Reminder to request Beta uplift.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

This one we need to uplift along with bug 1636728.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1636728

Comment 10

[Jonathan Watt [:jwatt]]

Comment on attachment 9172355 [details]
Bug 1661388 - Never show the print progress dialog if we're calling window.print() with the new UI. r=jwatt

Beta/Release Uplift Approval Request

• User impact if declined: Poor UX as dialog opens when it shouldn't
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172354 [details]
Bug 1661388 - Factor out the default print settings code. r=jwatt

Approved for 81.0b6.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0af0905f58d
https://hg.mozilla.org/releases/mozilla-beta/rev/45ae2e63e1c9

Comment 13

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on macOS 10.15, Ubuntu 18.04 and Windows 10x64. Verified using 82.0a1 (2020-09-09) and 81.0b8.