1661838 - Building with --disable-printing is broken

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Description

[[:fabrice] Fabrice Desré]

Regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1661388 changes to nsGlobalWindowOuter.cpp

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1661388

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I can take this. What are you using --disable-printing for?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(So I don't forget to fix it this week)

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I can take this. What are you using --disable-printing for?

b2g builds for KaiOS.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to [:fabrice] Fabrice Desré from comment #4)

b2g builds for KaiOS.

Does it have a big enough code-size impact that it warrants disabling? Android just disables window.print at runtime, and stubs the print service.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661838 - Fix builds with --disable-printing. r=#layout-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f3afede4904
Fix builds with --disable-printing. r=jwatt

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0f3afede4904

Comment 9

[Jonathan Watt [:jwatt]]

Comment on attachment 9173677 [details]
Bug 1661838 - Fix builds with --disable-printing. r=#layout-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: --disable-printing being broken for builds other people create. maybe also small chance of conflict with other patches we need.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173677 [details]
Bug 1661838 - Fix builds with --disable-printing. r=#layout-reviewers

Approved for 81.0b6.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/19b01f76ecba

Comment 12

[[:fabrice] Fabrice Desré]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

(In reply to [:fabrice] Fabrice Desré from comment #4)

b2g builds for KaiOS.

Does it have a big enough code-size impact that it warrants disabling? Android just disables window.print at runtime, and stubs the print service.

I don't know the code size impact, but I would say that if there's a build time flag it should work :) Thanks for fixing it anyway!