1661424 - [macOS] Icons are not visible for all the available accent colors on dark them

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect)

Description

[Anca Soncutean, Desktop QA]

Affected versions

• 82.0a1 (2020-08-26)
• 81.0b2

Affected platforms

• macOS 10.15

Steps to reproduce

1. Set the OS theme to dark
2. Open about:preferences and about:addons
3. Set random accent color (the colors that triggers the issue are intermittent)
4. Observe the tab bar

Expected result

• The icons are visible

Actual result

• The icons are visible

Regression range

• First bad: 2c3da065b36921048fbf974a1849a0ee36bae3b8
• Last good: 8be12844b53840e42fa3e2f46b46b0b806bb4631
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8be12844b53840e42fa3e2f46b46b0b806bb4631&tochange=2c3da065b36921048fbf974a1849a0ee36bae3b8
• Potential regressor: 1646842

Additional notes

• This issue can be seen on other areas (eg. new Print modal - see screenshot)

Suggested severity

• S4

Comment 1

[Sotaro Ikeda [:sotaro]]

I confirmed the problem on my mac PC.

:mstange, do you have any ideas about what could cause the problem?

Comment 2

[Markus Stange [:mstange]]

I think this has something to do with the context-fill properties and maybe the SVG surface cache. The affected image has fill: currentColor and -moz-context-properties: fill set on it. Once the STR are followed, the SVG becomes entirely transparent until this fill property is changed. For example, I'm currently in a state where the computed value of color on this element is rgb(249, 249, 250). Setting the fill property to any other color (e.g. rgb(249, 249, 251)) correctly applies the color, but setting it to rgb(249, 249, 250) makes the image disappear.
So there must be some poisoned cache key somewhere.

Comment 3

[Markus Stange [:mstange]]

(I was inspecting the <image class="tab-icon-image".../> in the tab bar.)

Comment 4

[Timea Cernea [:tbabos][inactive]]

I was able to reproduce this on the affected Nightly 82.0a1 (2020-08-26) on MacOS 10.15.
However, I could not reproduce this on the latest firefox Nightly 91.0a1 (2021-06-22) (64-bit) on the same MacOS 10.15 device, thus closing this as resolved:worksforme.