Closed Bug 1661618 Opened 3 years ago Closed 3 years ago

Update print toolbar item and app menu buttons depending on `print.tab_modal.enabled` value

Categories

(Toolkit :: Printing, enhancement, P1)

Product:
Toolkit
Component:
Printing
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox81 --- verified
firefox82 --- verified

People

(Reporter: emmamalysz, Assigned: emmamalysz)

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

Bug 1661618, update shortcut in app menu and toolbar tip for the toolbarbutton
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
No description provided.
Whiteboard: [print2020_v81]

We split this work out from bug 1659340. I'm going to assign it the same priority/severity as that, but we do have a patch up for it already.

Severity: -- → S3
Priority: -- → P1
Status: NEW → ASSIGNED
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ac24d2fdaf7
update shortcut in app menu and toolbar tip for the toolbarbutton r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/2ac24d2fdaf7

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9172564 [details]
Bug 1661618, update shortcut in app menu and toolbar tip for the toolbarbutton

Beta/Release Uplift Approval Request

  • User impact if declined: Will show the incorrect app menu icons and toolbar tips may be incorrrect.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Have the "print" toolbar button in the toolbar.

Mac:

  1. Open Firefox
  2. Turn on print.tab_modal.enabled
  3. Open main app menu
  4. Notice printing label includes shortcut
  5. Click on "print" button
  6. Get redirected to new print preview
  7. Hover over print toolbarbutton
  8. Notice tooltip includes the shortcut in text (stays the same)
  9. Click on toolbarbutton
  10. Be redirected to new print preview
  11. Turn off print.tab_modal.enabled
  12. Open main app menu
  13. Notice print button has shortcut (stays the same)
  14. Click on print button and be redirected to system dialog
  15. Hover over print toolbarbutton
  16. Notice tooltip includes the shortcut to the text (stays the same)
  17. Click print button and be redirected to system dialog printing

Windows/Linux:

  1. Open Firefox
  2. Turn on print.tab_modal.enabled
  3. Open main app menu
  4. Notice printing label now includes shortcut
  5. Click on "print" button
  6. Get redirected to new print preview
  7. Hover over print toolbarbutton
  8. Notice tooltip now includes the shortcut in text
  9. Click on toolbarbutton
  10. Be redirected to new print preview
  11. Turn off print.tab_modal.enabled
  12. Open main app menu
  13. Notice print button does not have shortcut
  14. Click on print button and be redirected to old print preview
  15. Hover over print toolbarbutton
  16. Notice tooltip does not include shortcut to the text (stays the same)
  17. Click print button and be redirected to old print preview
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No new strings, mostly shortcut text
  • String changes made/needed: n/a
Attachment #9172564 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9172564 [details]
Bug 1661618, update shortcut in app menu and toolbar tip for the toolbarbutton

Approved for 81.0b5.

Attachment #9172564 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with 82.0a1 (2020-09-04) and Fx 81.0b6 on Windows 10, macOS 10.14 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified
status-firefox82: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.