1661649 - Setting default sink id on a track with no prior sink id fails an assert

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P2)

Description

[Andreas Pehrson [:pehrsons]]

AudioStreamTrack::SetAudioOutputDevice seems to assume that when CrossGraphManager::Connect returns null we switch back from a non-null manager.

However, this is not always the case.

STR:
Have a media element playing a MediaStream with audio
Set the sink id of said media element to an explicit device
Set the sink id of said media element to the default device (i.e., "")
Add a fresh audio track to said media element

Expected:
Default device plays the fresh audio track

Actual: Assertion failure

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661649 - Minor test_setSinkId.html fixes. r?padenot

Depends on D88822

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661649 - Add mochitest. r?padenot

Depends on D88823

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661649 - Allow re-setting the default output device for a key on AudioStreamTrack. r?padenot

Depends on D88825

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33fa9e803dec
Minor test_setSinkId.html fixes. r=padenot
https://hg.mozilla.org/integration/autoland/rev/82373b2b236a
Add mochitest. r=padenot
https://hg.mozilla.org/integration/autoland/rev/054f617aae48
Allow re-setting the default output device for a key on AudioStreamTrack. r=padenot

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/33fa9e803dec
https://hg.mozilla.org/mozilla-central/rev/82373b2b236a
https://hg.mozilla.org/mozilla-central/rev/054f617aae48