1661668 - Do some cleaning in setSinkId code paths

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P2)

Description

[Andreas Pehrson [:pehrsons]]

In part because this code diverts from the styleguide in some places; in part so I can learn the code, and adapt it to what I find is more descriptive naming, for instance.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Rename CrossGraphManager to CrossGraphPort. r?padenot

"Manager" is vague, and it seems to mostly keep some members around rather than
managing them. Port is analogue to MediaInputPort in that it acts as a link
between two tracks. Neither type of port does very much heavy lifting -- they
are similarly dumb.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Avoid a RefPtr copy when creating a CrossGraphPort. r?padenot

Depends on D88812

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Make CrossGraphPort::mSourcePort const. r?padenot

Depends on D88813

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Clarify ownership of transmitter and receiver in CrossGraphPort. r?padenot

Depends on D88814

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Make CrossGraphTransmitter::mReceiver const. r?padenot

Depends on D88815

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Avoid returning raw pointers from CrossGraphPort::Connect because of the leak risk. r?padenot

Depends on D88816

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Remove unnecessary "virtual" keywords from CrossGraphPort.h. r?padenot

Depends on D88817

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Remove unnecessary "explicit" keyword from CrossGraphReceiver. r?padenot

Depends on D88818

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Don't let CrossGraphTransmitter masquerade as a ForwardedInputTrack. r?padenot

We've been working to reduce the depth of the class hierarchy, so let's not add
more. Broadening it is simple enough. This patch makes CrossGraphTransmitter a
sub class of ProcessedMediaTrack instead. As such it doesn't need a mSegment
member, among other things.

Depends on D88819

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Capture `this` in HTMLMediaElement::SetSinkId captures, for readability. r?padenot

Depends on D88820

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1661668 - Clarify MediaInputPort threading model. r?padenot

Depends on D88821

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1620a74a759
Rename CrossGraphManager to CrossGraphPort. r=padenot
https://hg.mozilla.org/integration/autoland/rev/0f719a4e5fe1
Avoid a RefPtr copy when creating a CrossGraphPort. r=padenot
https://hg.mozilla.org/integration/autoland/rev/374e873718fa
Make CrossGraphPort::mSourcePort const. r=padenot
https://hg.mozilla.org/integration/autoland/rev/32dae00d3edc
Clarify ownership of transmitter and receiver in CrossGraphPort. r=padenot
https://hg.mozilla.org/integration/autoland/rev/28e0a3c98004
Make CrossGraphTransmitter::mReceiver const. r=padenot
https://hg.mozilla.org/integration/autoland/rev/c7a33f295834
Avoid returning raw pointers from CrossGraphPort::Connect because of the leak risk. r=padenot
https://hg.mozilla.org/integration/autoland/rev/485cc39ac97e
Remove unnecessary "virtual" keywords from CrossGraphPort.h. r=padenot
https://hg.mozilla.org/integration/autoland/rev/2c7cd062626a
Remove unnecessary "explicit" keyword from CrossGraphReceiver. r=padenot
https://hg.mozilla.org/integration/autoland/rev/5f79701f61c3
Don't let CrossGraphTransmitter masquerade as a ForwardedInputTrack. r=padenot
https://hg.mozilla.org/integration/autoland/rev/3afcd9d68d5a
Capture `this` in HTMLMediaElement::SetSinkId captures, for readability. r=padenot
https://hg.mozilla.org/integration/autoland/rev/56cb58f400b5
Clarify MediaInputPort threading model. r=padenot

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e1620a74a759
https://hg.mozilla.org/mozilla-central/rev/0f719a4e5fe1
https://hg.mozilla.org/mozilla-central/rev/374e873718fa
https://hg.mozilla.org/mozilla-central/rev/32dae00d3edc
https://hg.mozilla.org/mozilla-central/rev/28e0a3c98004
https://hg.mozilla.org/mozilla-central/rev/c7a33f295834
https://hg.mozilla.org/mozilla-central/rev/485cc39ac97e
https://hg.mozilla.org/mozilla-central/rev/2c7cd062626a
https://hg.mozilla.org/mozilla-central/rev/5f79701f61c3
https://hg.mozilla.org/mozilla-central/rev/3afcd9d68d5a
https://hg.mozilla.org/mozilla-central/rev/56cb58f400b5