1661720 - Microsoft Print to PDF stuck in printing only Color outputs

Status: VERIFIED FIXED

(Core :: Printing: Setup, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Color2.gif

Affected versions

• 82.0a1 (BuildId:20200827212940)
• 81.0b3 (BuildId:20200827203325)

Affected platforms

• Windows 10 64bit

Unaffected platforms

• Ubuntu 20.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access any random webpage.
3. Hit CTRL + P.
4. Select the “Microsoft Print to PDF” option from the destination menu.
5. Change between "black & white" and "color" options from the Color mode dropdown menu.

Expected result

• The changes reflect inside the print preview and in actual print output.

Actual result

• The change doesn’t reflect in print preview nor in the actual print output.

Regression Window

• This seems to be a regression. I will investigate this asap.

Additional Information

• For further information regarding this issue please observe the attached screencast.
• [Suggested severity] S2

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Using mozregression I tracked this down to bug 1660986. Emilio, can you take a look at this?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Pretty sure this is bug 1661645.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

(Removing the whiteboard tag for easier tracking.)

Comment 4

[Emil Ghitta, QA [:emilghitta]]

Bug 1661645 has landed in m-c but I can still reproduce this issue using Firefox 82.0a1 (BuildId:20200901214943) test page

Adding the [print2020_81] tag back for now.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Based on the regressing bug, and that we get the "supportsColor" and "supportsMonochrome" from the platform side, I think this is a platform bug… (Fortunately, Emilio is already cc-ed on it. 😉)

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Odd, I can take a look.

Comment 7

[Boris Chiou [:boris]]

Mark S2 for now (and thanks for taking a look at this, Emilio.)

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Works for me on buildid: 20200902215721 on my Windows 10 laptop.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Okay, I could reproduce this. To reproduce it, probably the color mode option had been disabled once (by changing destination to one which is not color available).

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661720 - Don't claim to support monochrome for known PDF printers. r=bobowen,jwatt

They don't. Right now we get to GetDataFromPrinter from
nsDeviceContextSpecWin with mPrintInColor = false, but this copy back
and forth ends up setting it to true:

https://searchfox.org/mozilla-central/rev/2fb77a351ab34e9994f01377e2e12486a50f1737/widget/windows/nsDeviceContextSpecWin.cpp#448

Even if you avoid that, the printed file ends up being in color. This is
a bit of a hack, the right long-term fix is to detect whether the
printer supports monochrome in Gecko (add an attribute to nsIPrinter)
and communicate it to the front-end.

There's no equivalent to DC_COLORDEVICE but for monochrome in:

https://docs.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-devicecapabilitiesa

I think we could check if DC_FIELDS returns the COLOR field or such.
I'll poke at doing that but this is less risky.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661720 - Move monochrome detection to nsIPrinter. r=jwatt,bobowen

This moves the special cases to the printing platform code instead
(where it belongs).

The SupportsMonochrome() implementation is the only thing that I found
to work for the "Microsoft Print to PDF" driver, but other similar
drivers like XPS still claim to support monochrome (even though it's not
true). This should avoid the UI getting in a bad state as described in
the bug though, so may be better?

Depends on D89306

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d979307c639f
Don't claim to support monochrome for known PDF printers. r=jwatt

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cbbcc11ba1b
Move monochrome detection to nsIPrinter. r=bobowen

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d979307c639f

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8cbbcc11ba1b

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this something we need to take on Beta still or can this ride 82 to release?

Comment 17

[Jonathan Watt [:jwatt]]

It can ride.

Comment 18

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using old Nightly build (2020-08-28), verified that using Firefox 82.0b3 the Color Mode section is grayed out and disabled for Microsoft Print to PDF and Save to PDF.

Comment 19

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1084715