Closed Bug 1661949 Opened 4 years ago Closed 4 years ago

No longer able to search from address bar with ? prefix and keyword.enabled = false

Categories

(Firefox :: Address Bar, defect, P1)

80 Branch
Desktop
All
defect

Tracking

()

VERIFIED FIXED
82 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 --- verified
firefox82 --- verified

People

(Reporter: nuser97, Assigned: mak)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Set keywords.enabled = false
Type search text in the address bar, prefixed with a question mark

Actual results:

In Firefox 79, text is sent to the default search engine
In Firefox 80, receive the "Hmm. That address doesn’t look right." error

Expected results:

I expect the keywords.enabled setting only to apply for implicit searches, where no question mark prefix is specified, as was the case in Firefox 79 and earlier. When explicitly searching with the question mark prefix, the text should be sent to the default search engine.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Address Bar
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: No longer able to search from address bar with ? prefix and keywords.enabled = false → No longer able to search from address bar with ? prefix and keyword.enabled = false
See Also: → 1661982
See Also: 1661982

I can look at this, it is probably a regression due to the big refactoring in Bug 1648468 or Bug 1645521.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Regressed by: 1645521
Severity: -- → S2
Priority: -- → P1
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/0eacf15bc150 Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/ef2483cfdf64 Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Iteration: --- → 82.2 - Sep 7 - Sep 20
Flags: needinfo?(mak)

the landing of bug 1658964 may have broken my patch, I could not reproduce that failure before.

Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/711b8615bb3f Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Beta will require a different patch because the code differs.

Flags: needinfo?(mak)
Attached patch Beta patchSplinter Review

Approval Request Comment
[Feature/Bug causing the regression]: Urlbar code refactoring in bug 1645521
[User impact if declined]: Setting keyword.enabled to false doesn't allow to force searching in the urlbar with ?
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: yes, see comment 0
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: medium
[Why is the change risky/not risky?]: The affected behaviors are minimal, but of course there's always risk of unknown side effects, we have a lot of tests for the urlbar though
[String changes made/needed]:

Flags: needinfo?(mak)
Attachment #9174839 - Flags: approval-mozilla-beta?

Comment on attachment 9174839 [details] [diff] [review]
Beta patch

Can't say I'm crazy about taking this so late in the cycle, but the impact seems not-great for affected users. Thanks for adding a new test for this. Approved for 81.0b9.

Attachment #9174839 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Confirmed as verified fixed on Windows 10 x64bit and MacOS 10.14 with latest Nightly 82.0a1 (20200910152110) and Beta 81.0b9 (20200910180444).

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Regressions: 1667639
Regressions: 1719180
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: